Open
Conversation
l0r1s
requested review from
JohnReedV,
ales-otf,
gztensor,
open-junius,
sam0x17 and
shamil-gadelshin
l0r1s
added
the
skip-cargo-audit
sam0x17
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateSignedTransactionimpl and trait bounds — drand only usessend_unsigned_transaction(unsigned extrinsics with a signed payload), socreate_signed_transactionwas never calledCreateInherent/new_inherentwithCreateBare/new_bareacross all mock files and runtimeDetails
pallet_drand's offchain worker submits pulses viasigner.send_unsigned_transaction(), which creates bare extrinsics throughCreateBare::create_bare(). TheCreateSignedTransactiontrait and its implementations (runtime + 6 test mocks) were satisfying a trait bound but never invoked at runtime. This PR removes that dead code (~160 lines) and relaxespallet_drand::Configto only requireCreateBare<Call<Self>> + SigningTypes.