Skip to content

remove double record tao flow#2644

Merged
open-junius merged 2 commits intodevnet-readyfrom
fix-double-record-tao-flow
May 7, 2026
Merged

remove double record tao flow#2644
open-junius merged 2 commits intodevnet-readyfrom
fix-double-record-tao-flow

Conversation

@open-junius
Copy link
Copy Markdown
Contributor

Description

Fix a bug, the record tao flow called twice.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this May 7, 2026
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label May 7, 2026
Copy link
Copy Markdown
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly enough it doesn't break any test? Can we have a regression test on that so if it happens again, it will fail?

@open-junius
Copy link
Copy Markdown
Contributor Author

Surprisingly enough it doesn't break any test? Can we have a regression test on that so if it happens again, it will fail?
There are two failed test cases in #2643. I just checked that PR, then found out the bug.

@open-junius open-junius requested a review from l0r1s May 7, 2026 12:36
@open-junius open-junius merged commit fe31a96 into devnet-ready May 7, 2026
209 of 220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants