Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughMultiple styling and UI text updates across configurator, plugin, toolbar, layout, and icon SVG files: padding/margin adjustments, new popper classes and popper styles, theme variable addition, SVG icon geometry/clip changes, and a few text/comment replacements from "资源管理" to "工具管理". No JS logic or public API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/layout/src/DesignWorkspace.vue (1)
247-261: Consider extracting shared username-truncation styles.This block is very similar to
packages/toolbars/user/src/Main.vue; moving it to a shared utility/mixin would reduce style drift over time.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/layout/src/DesignWorkspace.vue` around lines 247 - 261, Extract the repeated username-truncation and user-icon styles from DesignWorkspace.vue into a shared style utility (e.g., a common CSS/SCSS partial or a Vue style mixin) and import it into both DesignWorkspace.vue and packages/toolbars/user/src/Main.vue; specifically move the .user-icon rules (margin-right, font-size) and the .name truncation rules (-webkit-line-clamp, -webkit-box-orient, overflow, text-overflow, word-break, width) into the shared file, replace the local block in DesignWorkspace.vue with an import/usage of that shared style, and update Main.vue to use the same shared import so both components reference the single source of truth for username truncation and icon spacing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/layout/src/DesignWorkspace.vue`:
- Around line 247-261: Extract the repeated username-truncation and user-icon
styles from DesignWorkspace.vue into a shared style utility (e.g., a common
CSS/SCSS partial or a Vue style mixin) and import it into both
DesignWorkspace.vue and packages/toolbars/user/src/Main.vue; specifically move
the .user-icon rules (margin-right, font-size) and the .name truncation rules
(-webkit-line-clamp, -webkit-box-orient, overflow, text-overflow, word-break,
width) into the shared file, replace the local block in DesignWorkspace.vue with
an import/usage of that shared style, and update Main.vue to use the same shared
import so both components reference the single source of truth for username
truncation and icon spacing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ecce8d04-4ebb-431b-af86-fa23ef5899a0
📒 Files selected for processing (2)
packages/layout/src/DesignWorkspace.vuepackages/toolbars/user/src/Main.vue
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/layout/src/ToolbarCollapse.vue (1)
44-47: Consider removing unusedIconPopupimport.
IconPopupis imported and registered as a component but is not used anywhere in the template.🧹 Suggested cleanup
import { Popover } from '@opentiny/vue' -import { IconPopup } from '@opentiny/vue-icon' import { getMergeMeta } from '@opentiny/tiny-engine-meta-register'components: { - TinyPopover: Popover as Component, - IconPopup: IconPopup() + TinyPopover: Popover as Component },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/layout/src/ToolbarCollapse.vue` around lines 44 - 47, The IconPopup component is imported and registered in ToolbarCollapse.vue but not used in the template; either remove the IconPopup import and its registration entry (the IconPopup() registration in the components object) or add the missing usage where intended. Update the components block to only include TinyPopover (Popover as Component) if you choose removal, and delete the IconPopup() call and its import to eliminate the unused symbol.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/plugins/robot/src/components/icons/mcp-icon.vue`:
- Around line 18-28: Remove the orphaned/invalid SVG id attributes in the
mcp-icon.vue SVG: delete the duplicate id="容器 6" attributes (they appear on
multiple <rect> elements) and either remove or sanitize id="矢量 667" so it
contains no whitespace (e.g., change to "矢量_667" or remove if unused). Ensure no
other SVG elements in this component retain duplicate or space-containing id
values; leave IDs only if they are actually referenced by scripts or CSS.
---
Nitpick comments:
In `@packages/layout/src/ToolbarCollapse.vue`:
- Around line 44-47: The IconPopup component is imported and registered in
ToolbarCollapse.vue but not used in the template; either remove the IconPopup
import and its registration entry (the IconPopup() registration in the
components object) or add the missing usage where intended. Update the
components block to only include TinyPopover (Popover as Component) if you
choose removal, and delete the IconPopup() call and its import to eliminate the
unused symbol.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 940256ec-741b-49dc-abad-10416fdef2fe
⛔ Files ignored due to path filters (9)
packages/design-core/assets/chat.svgis excluded by!**/*.svgpackages/design-core/assets/generate-code.svgis excluded by!**/*.svgpackages/design-core/assets/intelligent-construction.svgis excluded by!**/*.svgpackages/design-core/assets/more.svgis excluded by!**/*.svgpackages/design-core/assets/nest-attempt.svgis excluded by!**/*.svgpackages/design-core/assets/plugin.svgis excluded by!**/*.svgpackages/design-core/assets/think.svgis excluded by!**/*.svgpackages/design-core/assets/upload.svgis excluded by!**/*.svgpackages/design-core/assets/workspace-menu.svgis excluded by!**/*.svg
📒 Files selected for processing (10)
packages/layout/src/DesignToolbars.vuepackages/layout/src/ToolbarCollapse.vuepackages/plugins/robot/src/Main.vuepackages/plugins/robot/src/components/chat/FooterButton.vuepackages/plugins/robot/src/components/footer-extension/McpServer.vuepackages/plugins/robot/src/components/icons/mcp-icon.vuepackages/plugins/robot/src/components/icons/page-icon.vuepackages/plugins/robot/src/components/icons/study-icon.vuepackages/toolbars/generate-code/meta.jspackages/toolbars/view-setting/meta.js
✅ Files skipped from review due to trivial changes (1)
- packages/toolbars/generate-code/meta.js
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/layout/src/ToolbarCollapse.vue (1)
44-47: UnusedIconPopupimport and registration.
IconPopupis imported from@opentiny/vue-iconand registered in the components but is never used in the template. Consider removing it to reduce bundle size.♻️ Proposed cleanup
import { Popover } from '@opentiny/vue' -import { IconPopup } from '@opentiny/vue-icon' import { getMergeMeta } from '@opentiny/tiny-engine-meta-register' import { constants } from '@opentiny/tiny-engine-utils' import { computed } from 'vue' import type { Component } from 'vue' const { OPEN_DELAY } = constants export default { components: { - TinyPopover: Popover as Component, - IconPopup: IconPopup() + TinyPopover: Popover as Component },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/layout/src/ToolbarCollapse.vue` around lines 44 - 47, The IconPopup import and registration are unused: remove the IconPopup import from `@opentiny/vue-icon` and delete the IconPopup entry in the components object in ToolbarCollapse.vue (the IconPopup() registration) to avoid bundling unused code and ensure the template contains no references to IconPopup before removing.packages/plugins/robot/src/components/icons/mcp-icon.vue (1)
10-10: Non-standardcustomFrameattribute on SVG element.The
customFrameattribute is not a standard SVG attribute. If this is intentional for custom tooling or design software metadata, consider adding a brief comment. Otherwise, it can be safely removed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/plugins/robot/src/components/icons/mcp-icon.vue` at line 10, The svg in component mcp-icon.vue contains a non-standard attribute customFrame="url(`#clipPath_2`)"; remove this attribute from the SVG element (or, if it is required by external tooling, wrap a brief inline comment next to it documenting its purpose) so the SVG uses only standard attributes; search for customFrame in mcp-icon.vue to locate and either delete the attribute or replace it with a documented comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/plugins/robot/src/components/icons/page-icon.vue`:
- Around line 17-42: The SVG contains duplicate and invalid id attributes from
the design export: remove or rename the duplicate id="容器 7" attributes on the
<rect> elements and remove or replace the id="矢量 673" on the <path> so they are
unique and contain no ASCII whitespace; simplest fix is to delete these orphaned
id attributes entirely from the page-icon SVG (the <rect> and <path> elements
shown) since they are not referenced elsewhere.
In `@packages/plugins/robot/src/components/icons/study-icon.vue`:
- Around line 17-42: Remove the non-conforming/duplicate SVG id attributes in
the study-icon component: delete the two rect id="容器 8" attributes and remove or
replace the path id="矢量 670" (which contains whitespace) because they are
unused; if IDs are needed later, give them unique, valid names (no spaces) and
update any references accordingly.
---
Nitpick comments:
In `@packages/layout/src/ToolbarCollapse.vue`:
- Around line 44-47: The IconPopup import and registration are unused: remove
the IconPopup import from `@opentiny/vue-icon` and delete the IconPopup entry in
the components object in ToolbarCollapse.vue (the IconPopup() registration) to
avoid bundling unused code and ensure the template contains no references to
IconPopup before removing.
In `@packages/plugins/robot/src/components/icons/mcp-icon.vue`:
- Line 10: The svg in component mcp-icon.vue contains a non-standard attribute
customFrame="url(`#clipPath_2`)"; remove this attribute from the SVG element (or,
if it is required by external tooling, wrap a brief inline comment next to it
documenting its purpose) so the SVG uses only standard attributes; search for
customFrame in mcp-icon.vue to locate and either delete the attribute or replace
it with a documented comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 35774310-a5e7-4bdb-b620-c2bc2264dc5a
⛔ Files ignored due to path filters (9)
packages/design-core/assets/chat.svgis excluded by!**/*.svgpackages/design-core/assets/generate-code.svgis excluded by!**/*.svgpackages/design-core/assets/intelligent-construction.svgis excluded by!**/*.svgpackages/design-core/assets/more.svgis excluded by!**/*.svgpackages/design-core/assets/nest-attempt.svgis excluded by!**/*.svgpackages/design-core/assets/plugin.svgis excluded by!**/*.svgpackages/design-core/assets/think.svgis excluded by!**/*.svgpackages/design-core/assets/upload.svgis excluded by!**/*.svgpackages/design-core/assets/workspace-menu.svgis excluded by!**/*.svg
📒 Files selected for processing (10)
packages/layout/src/DesignToolbars.vuepackages/layout/src/ToolbarCollapse.vuepackages/plugins/robot/src/Main.vuepackages/plugins/robot/src/components/chat/FooterButton.vuepackages/plugins/robot/src/components/footer-extension/McpServer.vuepackages/plugins/robot/src/components/icons/mcp-icon.vuepackages/plugins/robot/src/components/icons/page-icon.vuepackages/plugins/robot/src/components/icons/study-icon.vuepackages/toolbars/generate-code/meta.jspackages/toolbars/view-setting/meta.js
✅ Files skipped from review due to trivial changes (1)
- packages/toolbars/generate-code/meta.js
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/plugins/robot/src/components/footer-extension/McpServer.vue
- packages/layout/src/DesignToolbars.vue
- packages/plugins/robot/src/Main.vue
- packages/toolbars/view-setting/meta.js
- packages/plugins/robot/src/components/chat/FooterButton.vue
hexqi
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
主要修改内容：
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Style
Chores