Skip to content

fix(chart): Hide Baidu Maps and Amap from the document and Repair the chart document #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Davont wants to merge 37 commits into
base: dev
Choose a base branch
from
+10 −4
Open

fix(chart): Hide Baidu Maps and Amap from the document and Repair the chart document #3867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
12ed2e5
fix: 【Charts】update charts snapshots
Davont May 20, 2024
049e055
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont May 21, 2024
e002b99
fix: 修复图表height为100%时的高度问题
Davont May 22, 2024
94a15eb
fix: 优化图表extend逻辑
Davont May 22, 2024
c411a5e
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jun 3, 2024
fe1d231
fix: 修复图表extend失效问题
Davont Jun 3, 2024
8fdc5c5
fix: 删除注释
Davont Jun 3, 2024
7e4e830
fix: 新增图表echartOption变量，以便用户获取echart配置
Davont Jun 5, 2024
19052b2
fix: 修复playground百度地图案例错误问题
Davont Jun 21, 2024
9c98733
fix: 修复图表option复杂变量失效问题
Davont Jun 21, 2024
256dae7
fix: 修改高德百度地图案例注释
Davont Jun 25, 2024
c77eac6
Merge branch 'dev' into dev
Davont Jun 26, 2024
85fc901
fix: chart-core添加cloneDeep引入
Davont Jun 28, 2024
613c9e7
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jul 1, 2024
38227ec
fix: 修改chart组件getFormatted函数判断逻辑
Davont Jul 1, 2024
16bf480
fix: 更新chart-core包版本为3.17.1
Davont Jul 2, 2024
3a582f7
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jul 11, 2024
4bb16ed
fix: 修复箱型图data为空数组时的报错问题
Davont Jul 11, 2024
d640562
fix: 添加图标属性逻辑的深拷贝
Davont Jul 11, 2024
9c2424d
fix: 删除注释文件
Davont Jul 11, 2024
fc4544f
fix: 修改图表打包
Davont Oct 22, 2024
6ef939b
fix: 图表打包指令修改
Davont Oct 23, 2024
ea0b581
Merge branch 'opentiny:dev' into dev
Davont Oct 25, 2024
804b0e6
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Dec 4, 2024
77a9acb
fix: huiCharts打包替换为Chart
Davont Dec 6, 2024
364f3d1
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Feb 18, 2025
de9b78f
Merge branch 'opentiny:dev' into dev
Davont Mar 5, 2025
1e1cd6c
fix: 新增图表解绑，解决内存泄漏问题
Davont Jul 23, 2025
68fbafd
Merge branch 'dev' of github.com:Davont/tiny-vue into dev
Davont Jul 24, 2025
3f8e8da
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Oct 13, 2025
bdc0985
fix: 添加chart实例的非空判断
Davont Oct 13, 2025
7855e1b
fix: 添加chart实例置空顺序
Davont Oct 14, 2025
467654f
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Dec 3, 2025
68cac15
fix: 将百度地图和高德地图从文档中隐藏，后续推荐用户使用原生地图
Davont Dec 3, 2025
746b9f1
fix: 修复chart图表文档api介绍未转义问题
Davont Dec 5, 2025
2bd21d4
fix: 修改错误
Davont Dec 8, 2025
4aa577d
fix: async-highlight组件type属性添加默认值
Davont Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/sites/demos/pc/menus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,8 @@ export const cmpMenus = [
{ 'nameCn': '词云图', 'name': 'Wordcloud Chart', 'key': 'chart-wordcloud' },
{ 'nameCn': '旭日图', 'name': 'Sunburst Chart', 'key': 'chart-sunburst' },
{ 'nameCn': '拓扑图', 'name': 'Graph Chart', 'key': 'chart-graph' },
{ 'nameCn': '百度地图', 'name': 'BaiduMap Chart', 'key': 'chart-baidu-map' },
{ 'nameCn': '高德地图', 'name': 'Autonavi Chart', 'key': 'chart-autonavi-map' },
// { 'nameCn': '百度地图', 'name': 'BaiduMap Chart', 'key': 'chart-baidu-map' },
// { 'nameCn': '高德地图', 'name': 'Autonavi Chart', 'key': 'chart-autonavi-map' },
{ 'nameCn': '箱形图', 'name': 'Boxplot Chart', 'key': 'chart-boxplot' },
{ 'nameCn': '进度图', 'name': 'Process Chart', 'key': 'chart-process' }
]
Expand Down
4 changes: 2 additions & 2 deletions examples/sites/src/components/api-docs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
<async-highlight
v-if="row.code"
:code="row.code.trim()"
:types="props.chartCode ? 'html' : 'ts'"
:type="props.chartCode ? 'chart' : ''"
></async-highlight>
Comment on lines 29 to 33
Copy link

@coderabbitai coderabbitai bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

cat examples/sites/src/components/async-highlight.vue

Repository: opentiny/tiny-vue

Length of output: 2689

🏁 Script executed:

git log --oneline -20 examples/sites/src/components/async-highlight.vue

Repository: opentiny/tiny-vue

Length of output: 151

🏁 Script executed:

fd async-highlight examples/sites/src/

Repository: opentiny/tiny-vue

Length of output: 110

🏁 Script executed:

git log --oneline -10 examples/sites/src/components/api-docs.vue

Repository: opentiny/tiny-vue

Length of output: 151

🏁 Script executed:

git show --stat HEAD

Repository: opentiny/tiny-vue

Length of output: 50374

The type prop passed to AsyncHighlight does not exist in the component definition.

AsyncHighlight only accepts code and filename props. The :type="props.chartCode ? 'chart' : ''" binding on lines 32 and similar usage elsewhere will be silently ignored. The component uses the filename prop to determine syntax highlighting language (checks if it ends with .vue for HTML highlighting, otherwise uses auto-detect). Either update AsyncHighlight to accept and use a type prop, or remove the type binding from api-docs.vue and rely on the filename prop instead.

🤖 Prompt for AI Agents 
In examples/sites/src/components/api-docs.vue around lines 29–33, the
AsyncHighlight component is being passed a non-existent type prop
(:type="props.chartCode ? 'chart' : ''"); AsyncHighlight only accepts code and
filename so this binding is ignored. Fix by removing the :type binding from the
AsyncHighlight usage and, if you need chart-specific highlighting, populate or
derive the filename prop (e.g., set filename to a .vue/.js/.chart-like value or
compute filename when props.chartCode is true) so the component can select the
correct language via its existing filename logic.

<div v-if="row.depTypes">
<async-highlight
v-for="(k, i) in row.depTypes"
:key="i"
:code="props.currentJson.types[k]?.code"
types="ts"
type="ts"
></async-highlight>
</div>
</template>
Expand Down
6 changes: 6 additions & 0 deletions examples/sites/src/components/async-highlight.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ export default defineComponent({
},
filename: {
type: String
},
type: {
type: String,
default: ''
}
},
setup(props) {
Expand All @@ -32,6 +36,8 @@ export default defineComponent({
// highlight和其他同步任务叠加容易形成长任务，改成异步消除长任务。
if (props.filename && props.filename.endsWith('.vue')) {
highlightCode.value = hljs.highlight(props.code, { language: 'html' }).value
} else if (props.type === 'chart') {
highlightCode.value = props.code
} else {
highlightCode.value = hljs.highlightAuto(props.code).value
}
Expand Down
Loading