chore(testdata): update Vitocal 300G CU401B sample data#697
Merged
CFenner merged 6 commits intoopenviess:masterfrom Feb 2, 2026
Merged
chore(testdata): update Vitocal 300G CU401B sample data#697CFenner merged 6 commits intoopenviess:masterfrom
CFenner merged 6 commits intoopenviess:masterfrom
Conversation
Adds API response dump for Vitocal 300G with CU401B controller. This test data will be used by upcoming feature PRs.
lackas
added a commit
to lackas/PyViCare
that referenced
this pull request
Jan 31, 2026
- Remove test data (split to PR openviess#697) - Rename getTemperature -> getTargetTemperature per review - Rename getTemperatureUnit -> getTargetTemperatureUnit per review
5 tasks
This property is exposed by Vitocal 300G but not yet implemented.
Member
|
Thanks, the data for 300G is very old. Lets remove the tests/response/Vitocal300G.json and update its tests if any. |
Minimal changes to make existing tests pass with new Vitocal300G_CU401B.json: - Update expected values (compressor hours, starts, temperatures) - Use circuit 1 instead of 0 (device configuration difference) - Skip load class tests (need statistics.load fallback from PR openviess#689) - Remove outdated Vitocal300G.json (from 2021) Comprehensive tests for new features (COP, cooling circuits, heating rod, refrigerant sensors, etc.) will be added with PR openviess#689.
Contributor
Author
|
Thanks @CFenner! Good point about the old data being outdated. Done - removed
Comprehensive tests for new features (COP, cooling circuits, heating rod, etc.) will be added with #689. |
Contributor
Author
|
Hi @CFenner, just a heads up that PR #689 is waiting on this one to merge. Once this is in, I'll rebase #689 and merge the comprehensive feature tests into |
Member
|
Ok, thanks, I’m currently on a conference with limited access. Hope I can check if I’m on the train later.
|
CFenner
changed the title
The device only has circuit "1" enabled, so getAvailableCircuits() returns ["1"]. The library creates circuits[0] for this single circuit, not circuits[1]. Fix index and clarify comment.
Available modes are read from API constraints and vary by device configuration. This device reports 3 modes: dhw, dhwAndHeating, standby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #689 as requested by @CFenner to make review easier. This test data enables the feature additions in that PR.