Add ventilation level volume flow getters #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to retrieve the configured volume flow (m³/h) for each ventilation level: - getLevelOneVolumeFlow() - getLevelTwoVolumeFlow() - getLevelThreeVolumeFlow() - getLevelFourVolumeFlow() Fixes openviess#630
CFenner
reviewed
Feb 12, 2026
| return int(self.getProperty("ventilation.volumeFlow.current.output")["properties"]["value"]["value"]) | ||
|
|
||
| @handleNotSupported | ||
| def getLevelOneVolumeFlow(self) -> int: |
Member
There was a problem hiding this comment.
These are static values, right? No actual sensor readings. I wonder if this should reflect in the function naming.. e.g getConfiguredLevelTwoVolumeFlow, getLevelTwoTargetVolumeFlow
These are static configuration values, not live sensor readings. Rename to make that distinction clear.
Contributor
Author
|
Good point — renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds methods to retrieve the configured volume flow (m³/h) for each ventilation level:
getLevelOneVolumeFlow()getLevelTwoVolumeFlow()getLevelThreeVolumeFlow()getLevelFourVolumeFlow()These values are exposed in
ventilation.levels.levelOnethroughlevelFourand represent the airflow configuration for each level.Fixes #630
Test plan