Add heating schedule setter for circuits#701
Draft
lackas wants to merge 1 commit intoopenviess:masterfrom
Draft
Conversation
Adds ability to set heating circuit schedules via the API, complementing the existing getHeatingSchedule() method. Fixes openviess#539
lackas
force-pushed
the
feature/heating-schedule-setter
branch
from
93e6ce0 to
c23842b
Compare
Contributor
Author
|
See also PR #368 which adds |
CFenner
reviewed
Feb 12, 2026
| } | ||
|
|
||
| @handleAPICommandErrors | ||
| def setHeatingSchedule(self, schedule): |
Contributor
Author
There was a problem hiding this comment.
Sure! The schedule structure is a nested dict (day keys → list of time slot dicts), so the most accurate type would be quite verbose. Would dict be sufficient, or do you have something more specific in mind? Note that the existing setDomesticHotWaterCirculationSchedule has the same untyped schedule parameter — happy to type that one too while we're at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds methods to set heating circuit schedules:
setHeatingSchedule(schedule)- set the heating schedule for a circuitgetHeatingScheduleModes()- get available schedule modes (e.g., reduced, normal, fixed)This complements the existing
getHeatingSchedule()method and follows the same pattern assetDomesticHotWaterCirculationSchedule().Fixes #539
Test plan
getHeatingScheduleModes()using Vitocal300G test data