feat: add DHW operating mode getters #705
Merged
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getDomesticHotWaterOperatingModes() and getDomesticHotWaterActiveOperatingMode() to HeatingDevice. Complements existing setDomesticHotWaterOperatingMode() setter. Tests cover Vitocal 250A, Vitocal 222S, and Vitovalor PT2 (3 different enum variants).
Member
|
I have no DHW on my device, so I really appreciate that you dive into this all the way up to Home Assistant. The way it is currently relying on the heating circuit is, I think, no longer up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getDomesticHotWaterOperatingModes()andgetDomesticHotWaterActiveOperatingMode()toHeatingDevice.These complement the existing
setDomesticHotWaterOperatingMode()setter (added in #319) by providing read access to:setModecommand constraints)Test coverage
Tests added for three devices with different mode sets:
Needed for home-assistant/core#154414 (ViCare DHW operating mode select entity).