Fix SIGILL handler: terminate instead of infinite loop#4094
Open
Fix SIGILL handler: terminate instead of infinite loop#4094
Conversation
…loop Problem: The SIGILL handler (onIllegal) called setShutdownRequest(2) and returned. SIGILL is a synchronous signal - the CPU raises it when encountering an illegal instruction. Unlike SIGINT/SIGTERM (asynchronous, delivered between instructions), returning from a SIGILL handler resumes execution at the same faulting instruction. This caused: 1. An infinite loop: fault -> handler -> return -> same fault -> ... 2. The process appeared "hanged" and had to be kill -9d
atobiszei
force-pushed
the
atobisze_sigill
branch
from
e469a3e to
6cf9fc4
Compare
atobiszei
force-pushed
the
atobisze_sigill
branch
from
04c414c to
539e775
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OVMS server signal handling to avoid an infinite fault/handler loop on synchronous SIGILL by terminating the process immediately after reporting the error.
Changes:
- Replace
SIGILLhandler logic to write a minimal diagnostic message and exit immediately. - Remove the (now-unreachable) post-loop log that depended on
shutdown_request == 2.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The SIGILL handler (onIllegal) called setShutdownRequest(2) and returned. SIGILL is a synchronous signal - the CPU raises it when encountering an illegal instruction. Unlike SIGINT/SIGTERM (asynchronous, delivered between instructions), returning from a SIGILL handler resumes execution at the same faulting instruction. This caused:
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``