Skip to content

Create speaker embeddings fix#4111

Open
michalkulakowski wants to merge 3 commits intomainfrom
mkulakow/speaker_fix
Open

Create speaker embeddings fix#4111
michalkulakowski wants to merge 3 commits intomainfrom
mkulakow/speaker_fix

Conversation

@michalkulakowski
Copy link
Copy Markdown
Collaborator

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings April 3, 2026 07:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Python dependency set for the demos/audio flow (notably the speaker-embedding preparation step) by adjusting pinned versions and adding missing direct dependencies required during runtime/model download.

Changes:

  • Downgrade pinned torch / torchaudio versions used by the audio demo requirements.
  • Adjust speechbrain version and add huggingface_hub / requests requirements.

Comment on lines +2 to +3
torch==2.5.1+cpu
torchaudio==2.5.1+cpu
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file pins torch/torchaudio to 2.5.1+cpu, but the audio demo README later installs demos/common/export_models/requirements.txt in the same environment, which pins torch==2.9.1+cpu (and does not pin torchaudio). Installing both requirement sets sequentially will force pip to upgrade/downgrade torch and can break either SpeechBrain or the export script depending on the final resolved versions. Consider aligning the torch (and torchaudio) versions across both requirements files, loosening the pin to a compatible range, or updating the demo instructions to use separate virtual environments for the two steps.

Suggested change
torch==2.5.1+cpu
torchaudio==2.5.1+cpu
torch==2.9.1+cpu
torchaudio==2.9.1+cpu

Copilot uses AI. Check for mistakes.
torch==2.5.1+cpu
torchaudio==2.5.1+cpu
speechbrain==1.0.2
huggingface_hub<1.0
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huggingface_hub<1.0 leaves the exact installed version floating, which can make the demo non-reproducible over time and can change behavior of model downloads unexpectedly. If a specific version is known to work with speechbrain==1.0.2, consider pinning it (or at least adding a tested minimum bound) to stabilize installs.

Suggested change
huggingface_hub<1.0
huggingface_hub==0.29.3

Copilot uses AI. Check for mistakes.
Michal Kulakowski added 2 commits April 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants