[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842
[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842anzr299 wants to merge 103 commits intoopenvinotoolkit:developfrom
Conversation
| from nncf.experimental.torch.fx.quantization.quantizer.openvino_quantizer import OpenVINOQuantizer | ||
| from nncf.quantization.algorithms.weight_compression.config import WeightCompressionParameters | ||
|
|
||
| OpenVINOQuantizer: TypeAlias = Any |
There was a problem hiding this comment.
This is to avoid import of OpenVINO quantizer whose only purpose is type hint
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 57 out of 106 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
tests/executorch/test_quantizer_compression.py:1
- This
xfailis not marked as strict, so if the underlying issue gets fixed the test may silently become XPASS and stop providing signal. Consider settingstrict=True(and ideally linking to the tracker/issue URL in the reason) so the suite forces follow-up when the failure condition changes.
daniil-lyakhov
left a comment
There was a problem hiding this comment.
Did you check the dot files manually? Is everything working ok?
|
Why not to call the pre-commit executorch test like |
Yes, I checked the graphs manually
@AlexanderDokuchaev asked me to seperate the executorch workflow from others. |
| # Copied from constraints.txt | ||
| # Tests and examples | ||
| pytest==9.0.3 | ||
| pytest==8.4.2 |
There was a problem hiding this comment.
@AlexanderDokuchaev is it okay? executorch==1.2.0 requires this pytest version.
Changes
Reason for changes
(reasons are in the same order as changes above)
CVS-176783
Tests
PTQ Conformance - PTQ-845 - Pass
Examples - https://github.com/openvinotoolkit/nncf/actions/runs/24825242781 - Pass
WC conformance - https://github.com/openvinotoolkit/nncf/actions/runs/24825249815 - Pass
pytest tests/executorch results:

All tests in tests/executorch pass