ddns-scripts: switch from API key to Private Access Token for gandi.net LiveDNS

[vivivitus]

📦 Package Details

Maintainer: @feckert

Description:
Gandi LiveDNS now only allows the use of Personal Access Tokens (PATs). There seems to be no way to create and use API keys, so the script could be adapted as suggested by @nicholasdavidson in #24194.

I am still unfamiliar with pull requests in GitHub and do not know what git am is or whether this can be used as a patch.

---

🧪 Run Testing Details

• OpenWrt Version: master
• OpenWrt Target/Subtarget: filogic
• OpenWrt Device: bananapi_bpi-r4

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

• It can be applied using git am
• It has been refreshed to avoid offsets, fuzzes, etc., using

  make package/<your-package>/refresh V=s

• It is structured in a way that it is potentially upstreamable
  _{(e.g., subject line, commit description, etc.)
  We must try to upstream patches to reduce maintenance burden.}

[GeorgeSapkin]

The commit message needs to follow the submissions guidelines regarding subject, message, author name and sign-off.

PKG_RELEASE in the Makefile needs a bump.

[vivivitus]

The commit message needs to follow the submissions guidelines regarding subject, message, author name and sign-off.

PKG_RELEASE in the Makefile needs a bump.

I apologize. If I need to submit another pull request, I will adhere more closely to the guidelines. I saw that you tagged this as “needs work.” What needs to be done?

[GeorgeSapkin]

What needs to be done?

The PKG_RELEASE bump.

[vivivitus]

What needs to be done?

The PKG_RELEASE bump.

Do I have to do a new pull request with the package release incremented or can i just add it to this pull request by another commit?

[GeorgeSapkin]

Don't make a new PR, update your existing commit and force-push it into this one.

[GeorgeSapkin]

Like I said previously, you need to update your existing commit. And you still need to follow all the commit formatting guidelines.

[vivivitus]

Like I said previously, you need to update your existing commit. And you still need to follow all the commit formatting guidelines.

Thanks for your reply. I'm a little lost because I don't quite understand what “commit formatting guidelines” means. do I have to include kernel, package name and so on? I know it's important for everyone to work together consistently, but maybe you can help me out. What's wrong or whats missing? And does the pull request have to be in a single commit?

[GeorgeSapkin]

Your commit should be named something like ddns-scripts: brief description of changes

It should have a commit message and the rest of should follow the submission guidelines. In general it's a good idea to look at how other people format their commits and follow suit.

This is a small self-contained change and should be in a single commit. It doesn't make sense to split the release bump into a separate one, since it's meaningless on its own.

[vivivitus]

Sorry, I didn't have time to take care of it earlier. I tried to undo both commits and create a single commit, but I also reset the first one and created a new one with the two changed files. That wasn't the best idea because it also changes the hash, of course, and the original commit is no longer available.

Can I still adjust the pull request somehow, or have I ruined it? Sorry for my lack of git knowledge.

[GeorgeSapkin]

In the future you should create your PRs from a feature branch and not from master, so that you don't get confused and overwrite your work when pulling from upstream. For now you can still add your commit to this PR, i.e. add it to your master branch and push.

[vivivitus]

Thanks for all your help. I pushed the changes to my fork, but the pull request is closed because I did a force push first so I could remove the old commits. I guess the pull request would have to reopened for this commit to reappear.

Update: Just found it.