watchcat: revert pinghosts quoting change #28154
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanddiaz
force-pushed
the
watchcat-revert-pinghosts
branch
from
f62515a to
771bdf7
Compare
This was referenced Dec 23, 2025
ivanddiaz
referenced
this pull request
Dec 23, 2025
The backend now correctly supports multiple IP addresses and avoids argument shifting when mmifacename is empty. Signed-off-by: Ivan Diaz <diaz.it@icloud.com>
Author
|
This PR fixes #28100 |
10 tasks
ivanddiaz
force-pushed
the
watchcat-revert-pinghosts
branch
2 times, most recently
from
94887ad to
280f668
Compare
Contributor
You should put that in your commit message just above your
|
The quoting added in r18 for pinghosts is not needed. Multi-host support remains fully functional, but the extra quotes caused inconsistent argument handling between /etc/init.d/watchcat and /usr/bin/watchcat.sh, especially for single-IP configurations. This revert removes the unnecessary quoting in the init script and LUCI, restoring consistent behavior while keeping multiple ping hosts supported. Fixes: openwrt#28100 (watchcat: error if only one address is specified in pinghosts) Signed-off-by: Ivan Diaz <diaz.it@icloud.com>
ivanddiaz
force-pushed
the
watchcat-revert-pinghosts
branch
from
280f668 to
be9fcd1
Compare
Author
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: rogerdammit@gmail.com
Description:
This PR reverts the unnecessary quoting added in r18 to the init script.
The original change attempted to support multiple pinghosts by wrapping values in extra quotes, but this is not needed. While multi-host support remains fully functional, the quoting caused inconsistent behavior between /etc/init.d/watchcat and /usr/bin/watchcat.sh, particularly in single-IP configurations.
🧪 Run Testing Details
✅ Formalities