zstd: add test-version.sh to fix CI version check failure#29422
Closed
commodo wants to merge 1 commit into
Closed
Conversation
zstdgrep and zstdless are shell script wrappers around the zstd binary; they do not output a version string. The generic CI version checker warns on both, which causes a "Some tests failed" exit in the CI runner. Add test-version.sh to override per-file version checks. The override verifies that /usr/bin/zstd --version contains the expected version and exits 0, which satisfies the CI infrastructure without falsely flagging the shell wrapper scripts. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Member
|
There is probably some confusion with the final log output. The |
Contributor
Author
|
So, then does this need to be closed? |
Member
|
If you look at the recent runs, the tests for zstd seem to pass: But the final status is not clearing the package name. So AFAICT this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
zstdgrep and zstdless are shell script wrappers around the zstd binary; they do not output a version string. The generic CI version checker warns on both, which causes a "Some tests failed" exit in the CI runner.
Add test-version.sh to override per-file version checks. The override verifies that /usr/bin/zstd --version contains the expected version and exits 0, which satisfies the CI infrastructure without falsely flagging the shell wrapper scripts.
🧪 Run Testing Details
✅ Formalities