Skip to content

treewide: add version check overrides#29428

Open
GeorgeSapkin wants to merge 13 commits into
openwrt:masterfrom
GeorgeSapkin:treewide-add-version-check-overrides
Open

treewide: add version check overrides#29428
GeorgeSapkin wants to merge 13 commits into
openwrt:masterfrom
GeorgeSapkin:treewide-add-version-check-overrides

Conversation

@GeorgeSapkin
Copy link
Copy Markdown
Member

Maintainer:

Description:

Add manual version checks or skip version checks where appropriate.

Depends on:


✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from ea0852b to 62b186d Compare May 11, 2026 17:13
@BKPepe BKPepe changed the title teewide: add version check overrides treewide: add version check overrides May 11, 2026
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 7167cd9 to 140aeb6 Compare May 11, 2026 19:54
Comment thread lang/python/python-pyserial/test-version.sh Outdated
Comment thread lang/python/python-tabulate/test-version.sh Outdated
@danielfdickinson
Copy link
Copy Markdown
Contributor

Noticed a couple of typos and commented. Hope it helps.

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch 7 times, most recently from 40fb9d6 to 4b5ff7c Compare May 13, 2026 19:22
@GeorgeSapkin GeorgeSapkin marked this pull request as ready for review May 13, 2026 19:25
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 4b5ff7c to 35916fa Compare May 14, 2026 12:12
Move existing version checks into override and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
Mark version check override as executable and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
Add manual version checks and skip version checks for dbus-utils.

Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 35916fa to 5b493ce Compare May 14, 2026 12:14
Mark version check override as executable and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Add explicit ftdi_eeprom version and a matching version check override.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Fixes: ac212e0 ("python-pyserial: add hostbuild")
Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Move existing version checks into override and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
Add version check override script.

Signed-off-by: George Sapkin <george@sapk.in>
Move existing version checks into override and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 5b493ce to e8fd3b2 Compare May 14, 2026 13:36
@GeorgeSapkin
Copy link
Copy Markdown
Member Author

@commodo any idea what's up with pyserial?

2026-05-14T20:42:35.6886508Z * Getting build dependencies for wheel...
2026-05-14T20:42:35.9207878Z 
2026-05-14T20:42:35.9208535Z Traceback (most recent call last):
2026-05-14T20:42:35.9209311Z   File "/builder/staging_dir/hostpkg/lib/python3.14/site-packages/pyproject_hooks/_impl.py", line 402, in _call_hook
2026-05-14T20:42:35.9209849Z     raise BackendUnavailable(
2026-05-14T20:42:35.9210072Z     ...<4 lines>...
2026-05-14T20:42:35.9210245Z     )
2026-05-14T20:42:35.9210726Z pyproject_hooks._impl.BackendUnavailable: Cannot import 'setuptools.build_meta'
2026-05-14T20:42:35.9211308Z 
2026-05-14T20:42:35.9211624Z ERROR Backend 'setuptools.build_meta:__legacy__' is not available.
2026-05-14T20:42:35.9363620Z make[2]: *** [Makefile:50: /builder/build_dir/target-x86_64_musl/pypi/pyserial-3.5/.built] Error 1
2026-05-14T20:42:35.9364562Z make[2]: Leaving directory '/feed/lang/python/python-pyserial'
2026-05-14T20:42:35.9367554Z time: package/feeds/packages_ci/python-pyserial/compile#0.75#0.35#0.97
2026-05-14T20:42:35.9375878Z     ERROR: package/feeds/packages_ci/python-pyserial failed to build.
2026-05-14T20:42:35.9380553Z make[1]: *** [package/Makefile:188: package/feeds/packages_ci/python-pyserial/compile] Error 1

I tried a few things, but nothing helps. I imagine this must be something trivial.

@commodo
Copy link
Copy Markdown
Contributor

commodo commented May 15, 2026

Often you need

HOST_BUILD_DEPENDS:=python-setuptools/host

and

PKG_BUILD_DEPENDS:=python-setuptools/host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants