hotplug-dispatch: redirect output to /dev/null#19
Merged
openwrt-bot merged 3 commits intoopenwrt:masterfrom Feb 9, 2026
Merged
hotplug-dispatch: redirect output to /dev/null#19openwrt-bot merged 3 commits intoopenwrt:masterfrom
openwrt-bot merged 3 commits intoopenwrt:masterfrom
Conversation
Member
Author
dangowrt
force-pushed
the
pr/hotplug-dispatch-redirect
branch
from
eaa3616 to
96dc0f7
Compare
Fix arguments validation (broken access to blob_attr property) Fixes: 03aab02 ("add a ubus handler that allows sending signals to processes") Signed-off-by: Kartashov Alexey <ya.antixrist@gmail.com> [improved commit message] Signed-off-by: Daniel Golle <daniel@makrotopia.org>
As documented in the readdir man page, support for d_type varies by filesystem. The ISO 9660 filesystem used in the x86 target's bootable ISO images always sets d_type to DT_UNKNOWN. Fall back to checking S_ISDIR(st_mode) when d_type is DT_UNKNOWN. Fixes: 08938fe ("procd: add hotplug-call dispatcher") Signed-off-by: Jeffrey Bosboom <jbosboom@jeffreybosboom.com>
During the hotplug call via the procd, a list is first created with the files in the hotplug.d directory. After that the scripts are then executed in lexical order. However, if a script is deleted after the list has been created, the following message is displayed on the tty console. Command failed: Not found /bin/sh: .: line 1: can't open '/etc/hotplug.d/ntp/25-travelmate_ntp': No such file or directory So that the message is not displayed in the tty console the 'stderr' must be redirected to '/dev/null'. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
dangowrt
force-pushed
the
pr/hotplug-dispatch-redirect
branch
from
96dc0f7 to
64f97ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dangowrt
During the hotplug call via the procd, a list is first created with the files in the hotplug.d directory. After that the scripts are then executed in lexical order. However, if a script is deleted after the list has been created, the following message is displayed on the tty console.
Command failed: Not found
/bin/sh: .: line 1: can't open '/etc/hotplug.d/ntp/25-travelmate_ntp': No such file or directory
So that the message is not displayed in the tty console the 'stderr' must be redirected to '/dev/null'.