various fixes to issues reported by @trailofbits#28
Merged
openwrt-bot merged 3 commits intoopenwrt:masterfrom Feb 9, 2026
Merged
various fixes to issues reported by @trailofbits#28openwrt-bot merged 3 commits intoopenwrt:masterfrom
openwrt-bot merged 3 commits intoopenwrt:masterfrom
Conversation
Due to a bug in hotplug-dispatch, the PATH env variable wasn't filtered, allowing authrorized callers the execution of commands via PATH environment variable filter bypass. Replace the call to strcmp with strncmp and limit the comparision to 5 characters to account for each character in "PATH=". Fixes: TOB-OWRT-4 Fixes: 08938fe ("procd: add hotplug-call dispatcher") Reported-by: Trail of Bits (@trailofbits) Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Check if any cgroups have been selected and string subtree_control has a length greater than 0 before reducing its length by 1, preventing to write outside of the bounds of the array in case no cgroups are selected. Fixes: ID: TOB-OWRT-6 Fixes: 16159bb ("jail: parse OCI cgroups resources") Reported-by: Trail of Bits Signed-off-by: Daniel Golle <daniel@makrotopia.org>
A stack buffer overflow may occur during path construction in instance_add_cgroup if the snprintf calls before the strcat call fill the 256-byte stack buffer. Check the length at all stages when creating and appending the string in the buffer and return an error in case it gets to long. Fixes: 83053b6 ("instance: add instances into unified cgroup hierarchy") Fixes: TOB-OWRT-8 Reported-by: Trail of Bits Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trail of Bits has reported a bunch issue for various OpenWrt sub-projects. This series addresses 3 data validation issues with rating "Informational" which were found in procd.