Merged
Conversation
Use mkdir_p() libubox helper function to create cgroup instance directories. This simplifies instance_add_cgroup() and also avoids returning an error in case the service directory already exists. Fixes: openwrt#31 Fixes: 7e5b324 ("instance: check length of names when creating cgroups") Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
@dangowrt @jfranzlx Qbittorrent does not start when the /etc/qbittorrent folder already exists. If you delete the folder, it will start once. After rebooting or updating the firmware, qbittorrent it still won't start until you delete the folder. |
Member
Author
|
Are you sure you are using procd after this commit? |
After the latest changes procd, stopped working. |
Member
Author
|
Please check which version of procd you currently got installed. 2026-02-17? |
Yes. I tried the new build today. procd | 2026.02.17~180ffccf-r1 |
Member
Author
|
Interesting. Before openwrt/openwrt@361885b there wasn't any check whether cgroup for the instance is actually created, now there are several checks along the way. diff --git a/service/instance.c b/service/instance.c
index a456b8c..6e13cf5 100644
--- a/service/instance.c
+++ b/service/instance.c
@@ -677,7 +677,7 @@ instance_start(struct service_instance *in)
ret = instance_add_cgroup(in->srv->name, in->name);
if (ret)
ULOG_WARN("failed adding instance cgroup for %s: %s\n",
- in->srv->name, strerror(ret));
+ in->srv->name, strerror((ret < 0)? -ret : ret));
instance_run(in, opipe[1], epipe[1]);
return; |
|
I can't build it. After patching, error One more parenthesis was missing at the end. Now building |
|
Member
Author
Strange, no more cgroups related error message at all now. Just that the instance of qbittorrent itself is crashing... |
I found the reason. I have a rule to save the
|
|
Previously, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mkdir_p() libubox helper function to create cgroup instance directories. This simplifies instance_add_cgroup() and also avoids returning an error in case the service directory already exists.
Fixes: #31
Fixes: 7e5b324 ("instance: check length of names when creating cgroups")