Skip to content

[#460] WebPageMetadataServiceImpl에서 Sendable 이슈를 해결한다 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 1 commit into from
May 25, 2026
Merged

[#460] WebPageMetadataServiceImpl에서 Sendable 이슈를 해결한다 #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions Application/DevLogInfra/Sources/Service/WebPageMetadataServiceImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,13 @@ final class WebPageMetadataServiceImpl: WebPageMetadataService {
private func extractImageURL(from imageProvider: NSItemProvider?, url: URL) async throws -> URL? {
guard let imageProvider else { return nil }

guard let data = try await imageData(from: imageProvider) else { return nil }
return try await imageStore.saveImage(data, for: url)
}

private func imageData(from imageProvider: NSItemProvider) async throws -> Data? {
return try await withCheckedThrowingContinuation { continuation in
// `[imageStore]`은 배열이 아니고 캡쳐 리스트
// 명시적으로 imageStore을 캡쳐하겠다고 작성한 것
imageProvider.loadObject(ofClass: UIImage.self) { [imageStore] image, error in
imageProvider.loadObject(ofClass: UIImage.self) { image, error in
Comment thread
opficdev marked this conversation as resolved.
if let error {
continuation.resume(throwing: error)
return
Expand All @@ -89,14 +92,7 @@ final class WebPageMetadataServiceImpl: WebPageMetadataService {
return
Comment thread
opficdev marked this conversation as resolved.
}

Task {
do {
let fileURL = try await imageStore.saveImage(data, for: url)
continuation.resume(returning: fileURL)
} catch {
continuation.resume(throwing: error)
}
}
continuation.resume(returning: data)
}
}
}
Expand Down