Skip to content

chore: release v3.4.0#608

Merged
carlos-alm merged 1 commit intomainfrom
release/3.4.0
Mar 26, 2026
Merged

chore: release v3.4.0#608
carlos-alm merged 1 commit intomainfrom
release/3.4.0

Conversation

@carlos-alm
Copy link
Copy Markdown
Contributor

Summary

  • Bump version to 3.4.0
  • Add CHANGELOG entry for all 51 commits since v3.3.1
  • Update ROADMAP: Phase 5 (TypeScript Migration) marked complete, Phase 6 status updated
  • Update BACKLOG: Leiden vendoring unblocks community leverage features
  • Update README: Phase 4/5 marked complete, Phase 6 in progress, Louvain → Leiden
  • Restore missing libc fields in package-lock.json for Linux platform binaries

Test plan

  • npm install succeeds with updated lock file
  • CHANGELOG renders correctly on GitHub
  • ROADMAP checklist items match actual codebase state

@claude
Copy link
Copy Markdown

claude bot commented Mar 26, 2026

Claude finished @carlos-alm's task —— View job


🔍 Reviewing Release PR v3.4.0

Todo List:

  • Phase 1: Root cause analysis - determine legitimacy of release
  • Phase 2: Configuration change detection
  • Phase 3: Test integrity assessment
  • Phase 4: Code quality review
  • Phase 5: Backlog compliance evaluation
  • Final Assessment: Provide rating and recommendation

Root Cause Analysis

Problem Being Solved: This is a legitimate v3.4.0 release marking completion of the TypeScript migration milestone (Phase 5 in ROADMAP.md). All 271 source files have been migrated from JavaScript to TypeScript.

Why This Approach: Standard release procedure using commit-and-tag-version to auto-generate changelog from 51 commits since v3.3.1. Version sync includes both npm package and Rust crate.

Risk Assessment: Low risk. No code changes - only version bumps, generated changelog, roadmap updates, and package-lock.json restoration.

Backlog Compliance

  • Zero-dep: ✓ — No new runtime dependencies added
  • Foundation-aligned: ✓ — Pure release administrative changes, no principle conflicts
  • Problem-fit: N/A — Release mechanics, not feature delivery
  • Breaking: No — Version bump only, no API/schema changes
  • Tier: Release maintenance (not backlog-categorized)

Critical Concerns

None identified. All changes are appropriate for a release:

✅ Legitimate Changes Verified:

  • Version bumps: package.json 3.4.0, Cargo.toml 3.4.0 ✓
  • Changelog: Auto-generated from 51 commits, covers TypeScript migration completion ✓
  • Roadmap updates: Phase 5 (TypeScript Migration) marked complete, Phase 6 status updated ✓
  • Package-lock restoration: Missing libc fields restored for Linux platform binaries ✓

✅ No High-Risk Changes:

  • No linting/build configuration relaxation
  • No test timeouts or threshold modifications
  • No disabled TypeScript strict mode flags
  • No test assertion weakening

✅ Change Authenticity:

  • Changelog accurately reflects the 51 commits since v3.3.1
  • Roadmap updates align with actual codebase state (TypeScript migration complete)
  • Package-lock.json changes only restore missing metadata, no dependency changes

Final Recommendation

  • Rating: ⭐⭐⭐⭐☆ (4/5)
  • Action: APPROVE
  • Reasoning: Clean, legitimate release with proper version management. TypeScript migration completion is a significant milestone. Only minor deduction for outdated optional dependency versions (3.3.1 instead of 3.4.0), but this doesn't affect functionality since they're platform-specific native binaries that will be published separately.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 26, 2026

Greptile Summary

This is a clean release PR bumping codegraph to v3.4.0. It synchronises all version fields (package.json, package-lock.json, crates/codegraph-core/Cargo.toml), adds a comprehensive CHANGELOG entry covering 51 commits, and updates README.md, ROADMAP.md, and BACKLOG.md to reflect two newly completed phases: TypeScript Migration (Phase 5) and the Leiden community-detection vendoring. The package-lock.json also restores missing libc fields for the three Linux platform binaries and corrects the engines.node floor from >=20 to >=22.6 to match what package.json already declared.\n\n- All version fields (package.json, package-lock.json, Cargo.toml) are consistently updated to 3.4.0.\n- libc fields (glibc/musl) are correctly restored for linux-arm64-gnu, linux-x64-gnu, and linux-x64-musl optional dependencies — important for npm to select the right binary on Linux.\n- The engines.node correction in package-lock.json (>=20>=22.6) aligns the lock with package.json and CLAUDE.md, which have required Node 22.6 since a prior PR.\n- CHANGELOG, README, ROADMAP, and BACKLOG are all internally consistent with each other and with the actual codebase state described in prior PRs.\n- One minor follow-up: CLAUDE.md still describes features/communities.ts as "Louvain community detection" — it should be updated to "Leiden" now that the migration is complete.

Confidence Score: 5/5

Safe to merge — all changes are documentation, version bumps, and a lock-file restoration with no logic modifications.

Every changed file is either a version field, a documentation/roadmap update, or a lock-file correction (missing libc fields and a stale engine floor). No source code is modified, no APIs change, and all version numbers are mutually consistent. The single comment filed is a non-blocking style suggestion in CLAUDE.md that can be addressed in a follow-up commit.

No files require special attention; the only follow-up is updating CLAUDE.md to say 'Leiden' instead of 'Louvain'.

Important Files Changed

Filename Overview
CHANGELOG.md Adds well-structured v3.4.0 entry with 51 commits summarized across features, bug fixes, performance, tests, and chores; links to individual PRs throughout
README.md Updates community detection from Louvain to Leiden in two places, marks phases 6 and 7 complete, and advances Phase 8 (Native Analysis Acceleration) to 7-of-8 complete
crates/codegraph-core/Cargo.toml Single-field version bump from 3.3.1 to 3.4.0, consistent with package.json and package-lock.json
docs/roadmap/BACKLOG.md Updates last-updated date and flips Tier 1e.1 Community leverage items from 'blocked' to 'unblocked' now that Leiden vendoring is complete
docs/roadmap/ROADMAP.md Bumps current version to 3.4.0, corrects Phase 5 completion version from v3.3.1 to v3.4.0, marks Phase 5 complete, and replaces stale in-progress migration tables with concise completed summaries
package-lock.json Version bumped to 3.4.0; node engine corrected from >=20 to >=22.6 to match package.json; libc fields restored for three Linux platform binaries (arm64-gnu, x64-gnu, x64-musl)
package.json Version-only bump from 3.3.1 to 3.4.0; all other fields unchanged

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["chore: release v3.4.0"] --> B["Version bumps"]
    A --> C["Documentation updates"]
    A --> D["package-lock.json fixes"]

    B --> B1["package.json\n3.3.1 → 3.4.0"]
    B --> B2["package-lock.json\n3.3.1 → 3.4.0"]
    B --> B3["crates/codegraph-core/Cargo.toml\n3.3.1 → 3.4.0"]

    C --> C1["CHANGELOG.md\nAdd v3.4.0 entry (51 commits)"]
    C --> C2["README.md\nLouvain → Leiden\nPhase 6 ✅ Phase 7 ✅ Phase 8 in progress"]
    C --> C3["docs/roadmap/ROADMAP.md\nPhase 5 complete (v3.4.0)\nPhase 6 in progress (7/8)"]
    C --> C4["docs/roadmap/BACKLOG.md\nTier 1e.1 items unblocked"]

    D --> D1["Restore libc fields\nlinux-arm64-gnu → glibc\nlinux-x64-gnu → glibc\nlinux-x64-musl → musl"]
    D --> D2["Correct engines.node\n>=20 → >=22.6"]
Loading

Comments Outside Diff (1)

  1. CLAUDE.md, line 118 (link)

    P2 CLAUDE.md still references Louvain

    CLAUDE.md line 118 describes features/communities.ts as "Louvain community detection", but v3.4.0 completes the Leiden vendoring (PRs feat: vendor Leiden community detection, remove graphology #545, feat: implement true Leiden probabilistic refinement (backlog #103) #552, feat: true Leiden probabilistic refinement (Algorithm 3) #556) and removes the graphology-communities-louvain dependency. AI agents and contributors reading CLAUDE.md for architectural context will get a stale picture of the communities subsystem.

    Context Used: CLAUDE.md (source)

Reviews (1): Last reviewed commit: "chore: release v3.4.0" | Re-trigger Greptile

@carlos-alm carlos-alm merged commit 9107ec2 into main Mar 26, 2026
22 checks passed
@carlos-alm carlos-alm deleted the release/3.4.0 branch March 26, 2026 03:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant