-
Notifications
You must be signed in to change notification settings - Fork 8
fix(wasm): extract call-site AST nodes in ast-store-visitor #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−36
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5637d9a
fix(wasm): extract call-site AST nodes in ast-store-visitor (#674)
carlos-alm a67cb64
fix(wasm): match native arguments-only recursion and multi-field call…
carlos-alm e412edf
test(fixture): add chained-call pattern to exercise call-in-function-…
carlos-alm a9e7f4c
Merge branch 'main' into fix/674-wasm-call-site-ast
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract_call_nameThe native Rust implementation (
helpers.rsline 442) checks three field names in order —"function","method", and"name"— to accommodate different Tree-sitter grammars:The WASM
extractCallNameonly checks"function". While the JavaScript/TypeScript Tree-sitter grammar always uses"function"forcall_expression, if this helper is ever reused for another grammar (e.g., Python uses"function"but others use"method"or"name"), it would silently fall back to the text-split heuristic instead of the precise field lookup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a67cb64.
extractCallNamenow checks all three fields in the same order as the nativeextract_call_nameinhelpers.rs:442:This matches the native Rust implementation exactly and ensures grammar compatibility across languages.