Skip to content

fix(test): remove constant-kind exclusion from parity test (#676) #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 2 commits into from
Mar 30, 2026
+2 −11
Merged

fix(test): remove constant-kind exclusion from parity test (#676) #680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b78a3
fix(test): remove constant-kind exclusion from parity test (#676)
carlos-alm Mar 30, 2026
c74ba46
Merge branch 'main' into fix/native-constant-scope
carlos-alm Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions tests/integration/build-parity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,20 @@ function copyDirSync(src, dest) {

function readGraph(dbPath) {
const db = new Database(dbPath, { readonly: true });
// PARITY BUG (#676): Native engine extracts local `const` variables inside
// functions as top-level constants; WASM correctly limits to program-level.
// Fix: crates/codegraph-core/src/extractors/javascript.rs (find_parent_of_types guard)
// Remove this exclusion once #676 is resolved.
const nodes = db
.prepare(
"SELECT name, kind, file, line FROM nodes WHERE kind != 'constant' ORDER BY name, kind, file, line",
)
.prepare('SELECT name, kind, file, line FROM nodes ORDER BY name, kind, file, line')
.all();
const edges = db
.prepare(`
SELECT n1.name AS source_name, n2.name AS target_name, e.kind
FROM edges e
JOIN nodes n1 ON e.source_id = n1.id
JOIN nodes n2 ON e.target_id = n2.id
WHERE n1.kind != 'constant' AND n2.kind != 'constant'
ORDER BY n1.name, n2.name, e.kind
`)
.all();
const roles = db
.prepare(
"SELECT name, role FROM nodes WHERE role IS NOT NULL AND kind != 'constant' ORDER BY name, role",
)
.prepare('SELECT name, role FROM nodes WHERE role IS NOT NULL ORDER BY name, role')
.all();

// ast_nodes may not exist on older schemas — read if available
Expand Down
Loading