remove the tmpdir after orca-cli installation #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions to remove the tmp directory used for downloading and extracting orca-cli tool:
rm -rf "${tmpdir}"
| /usr/bin/pgrep -q oahd || log_info "M1 CPU requires Rosetta 2, which appears to be missing. Install it by running: '/usr/sbin/softwareupdate --install-rosetta'" | ||
| fi | ||
|
|
||
| rm -rf "${tmpdir}" |
There was a problem hiding this comment.
this is very dangerous, in case of issues we might delete customer data. is it really necessary ?
Author
There was a problem hiding this comment.
@yinonsh-orca We delete the temporary directory which we have created for orca-cli installation:
tmpdir=$(mktmpdir)
After installing the orca-cli, we should be OK to delete the directory created by us.
Author
There was a problem hiding this comment.
@yinonsh-orca / @liorj-orca Any thoughts on my last comment.?
There was a problem hiding this comment.
If the directory is created under /tmp, there's no need to delete it.
@liorj-orca what do you think ? Was this raised by customers ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions to remove the tmp directory used for downloading and extracting orca-cli tool: rm -rf "${tmpdir}"