Skip to content

Add QA workflow for OneUnit testing #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nixel2007 merged 2 commits into from
Jan 2, 2026
Merged

Add QA workflow for OneUnit testing #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8142431
Add QA workflow for OneUnit testing
nixel2007 Jan 2, 2026
1e34d81
Update coverage report path in sonar-project.properties
nixel2007 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/qa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# С тестированием OneUnit
name: Контроль качества

on:
push:
pull_request:
workflow_dispatch:

jobs:
sonar:
uses: autumn-library/workflows/.github/workflows/sonar.yml@main
with:
coveralls: true
github_repository: oscript-library/ovm
oscript_version: 'dev'
test_engine: 'oneunit'
secrets:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace at the end of this line. Trailing whitespace should be removed to maintain clean code formatting.

Suggested change
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ sonar.sources=./src
# Encoding of the source code. Default is default system encoding
sonar.sourceEncoding=UTF-8

sonar.coverageReportPaths=coverage/genericCoverage.xml
sonar.coverageReportPaths=out/genericCoverage.xml
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Search for references to the old coverage path
rg 'coverage/genericCoverage\.xml' --type-list | head -20

Repository: oscript-library/ovm

Length of output: 452

🏁 Script executed:

# Search for any references to coverage/genericCoverage in the entire codebase
rg 'coverage/genericCoverage' -i

Repository: oscript-library/ovm

Length of output: 135

🏁 Script executed:

# Look for workflow files to verify new configuration
find .github -name "*.yaml" -o -name "*.yml" 2>/dev/null | head -20

Repository: oscript-library/ovm

Length of output: 148

🏁 Script executed:

# Check if qa.yaml exists and inspect its configuration
cat .github/workflows/qa.yaml 2>/dev/null || echo "File not found"

Repository: oscript-library/ovm

Length of output: 441

🏁 Script executed:

# Also check for sonar.yml to understand the coverage report configuration
cat .github/workflows/sonar.yml 2>/dev/null || echo "File not found"

Repository: oscript-library/ovm

Length of output: 77

🏁 Script executed:

# Search for any other references to coverage path in config files
rg 'genericCoverage' -t yaml -t yml -t properties

Repository: oscript-library/ovm

Length of output: 90

🏁 Script executed:

# Search for all references to coverage in the codebase
rg 'coverage' --type-add 'config:*.{yaml,yml,properties}' -tconfig -tpython -tjs

Repository: oscript-library/ovm

Length of output: 93

🏁 Script executed:

# Check the tasks/coverage.os file to understand how it generates coverage
cat tasks/coverage.os

Repository: oscript-library/ovm

Length of output: 2093

🏁 Script executed:

# Search for out/ directory references in workflow or config files
rg 'out/genericCoverage' -i

Repository: oscript-library/ovm

Length of output: 137

🏁 Script executed:

# Check if there are other script files that might be handling coverage
find . -name "*.os" -o -name "*.bat" -o -name "*.sh" | grep -i coverage

Repository: oscript-library/ovm

Length of output: 82

🏁 Script executed:

# Look for configuration that might specify output directories
rg 'coverageReportPaths|coverage.*report|out.*coverage' -i

Repository: oscript-library/ovm

Length of output: 137

🏁 Script executed:

# Check for file copy/move operations in workflow files
rg 'cp|mv|copy|move' .github/workflows/ -i

Repository: oscript-library/ovm

Length of output: 45

🏁 Script executed:

# Look for any script that might handle the coverage output directory
rg 'out.*coverage|coverage.*out' -i

Repository: oscript-library/ovm

Length of output: 137

🏁 Script executed:

# Check if there's a build script or setup that creates out directory
find . -name "build*" -o -name "setup*" -o -name "Makefile" 2>/dev/null

Repository: oscript-library/ovm

Length of output: 45

🏁 Script executed:

# Search for any reference to out/ directory in the entire repo
rg 'out/' --type yaml --type properties -B2 -A2

Repository: oscript-library/ovm

Length of output: 97

Исправьте путь генерации отчёта покрытия в соответствии с новой конфигурацией.

Обнаружено несоответствие: файл sonar-project.properties ожидает отчёт по пути out/genericCoverage.xml, но скрипт tasks/coverage.os генерирует отчёт по пути coverage/genericCoverage.xml. SonarQube не найдёт отчёт и не сможет выполнить проверку качества.

Требуется обновить tasks/coverage.os для создания каталога и записи отчёта в out/genericCoverage.xml вместо coverage/genericCoverage.xml.

🤖 Prompt for AI Agents 
In sonar-project.properties around line 17 the sonar.coverageReportPaths is set
to out/genericCoverage.xml but the coverage generator writes to
coverage/genericCoverage.xml; update tasks/coverage.os to create the out
directory if missing (mkdir -p out) and change the report output path to
out/genericCoverage.xml (ensure the script writes the report to that path and
preserves exit codes/permissions).

Loading