Conversation
The openstacksdk types `Connection.image` as a union of v1 and v2 proxies, but the codebase relies on v2-only methods (import_image, add_tag, remove_tag, deactivate_image, reactivate_image). Add an `_image` property that casts to the v2 proxy and route the v2-only call sites through it. AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
Contributor
|
I cannot reproduce any errors. Is this fixing a CI error? |
ideaship
reviewed
May 4, 2026
Contributor
ideaship
left a comment
ideaship
left a comment
There was a problem hiding this comment.
Can you say more about the failure this PR fixes? I'd like to reproduce it or study the CI log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openstacksdk types
Connection.imageas a union of v1 and v2 proxies, but the codebase relies on v2-only methods (import_image, add_tag, remove_tag, deactivate_image, reactivate_image). Add an_imageproperty that casts to the v2 proxy and route the v2-only call sites through it.AI-assisted: Claude Code