Skip to content

AO3-7238 Add work's last updated time to akismet comment spam checks #5521

Merged
Bilka2 merged 12 commits intootwcode:masterfrom
omerfaruk-pseud:AO3-7238
Jan 22, 2026
Merged

AO3-7238 Add work's last updated time to akismet comment spam checks #5521
Bilka2 merged 12 commits intootwcode:masterfrom
omerfaruk-pseud:AO3-7238

Conversation

@omerfaruk-pseud
Copy link
Copy Markdown
Member

@omerfaruk-pseud omerfaruk-pseud commented Dec 24, 2025

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7238

Purpose

Adds the timestamp of modification of the parent which the comment was posted on (revision time for works and creation time for admin posts). It is to improve akismet's comment checks for better spam detection accuracy.

Credit

ömer faruk (he/him)

@sarken
Copy link
Copy Markdown
Collaborator

sarken commented Dec 24, 2025

I think tests similar to these tests of various akismet_attributes' values would be fine. Maybe we could use travel_to to make sure the work and chapter have different revised_at dates and the correct one gets used in the akismet_attribute?

Comment thread app/models/comment.rb Outdated
Copy link
Copy Markdown
Member

@marcus8448 marcus8448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment thread app/models/comment.rb Outdated
Comment thread spec/models/comment_spec.rb Outdated
Copy link
Copy Markdown
Member

@marcus8448 marcus8448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@Bilka2 Bilka2 merged commit 3fa5f25 into otwcode:master Jan 22, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants