Skip to content

AO3-7379 Add delimiters to collection blurb stats numbers #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bre-nana wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −8
Open

AO3-7379 Add delimiters to collection blurb stats numbers #5783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584b381
AO3-7379 add locale keys to internationalise text
bre-nana May 4, 2026
ca1a0b6
AO3-7379 add delimiters to large numbers
bre-nana May 4, 2026
9775ec1
AO3-7379 alphabetise locale config
bre-nana May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/views/collections/_collection_blurb.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,18 @@
<!--stats-->
<dl class="stats">
<% if (@challenges_count = collection.children.count) > 0 %>
<dt class="collections"><%= ts("Challenges/Subcollections:") %></dt>
<dd class="collections"><%= link_to(@challenges_count, collection_collections_path(collection)) %></dd>
<dt class="collections"><%= t(".challenges_subcollections") %></dt>

Check failure on line 45 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `collections` detected matching the pattern `collections`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:45:8: Deprecated class `collections` detected matching the pattern `collections`. Avoid the plural form of these classes.
<dd class="collections"><%= link_to(number_with_delimiter(@challenges_count), collection_collections_path(collection)) %></dd>

Check failure on line 46 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `collections` detected matching the pattern `collections`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:46:8: Deprecated class `collections` detected matching the pattern `collections`. Avoid the plural form of these classes.
<% end %>
<% if collection.challenge? && collection.prompt_meme? %>
<dt class="prompts"><%= ts("Prompts:") %></dt>
<dd class="prompts"><%= link_to(collection.prompts.count.to_s, collection_requests_path(collection)) %></dd>
<dt class="prompts"><%= t(".prompts") %></dt>
<dd class="prompts"><%= link_to(number_with_delimiter(collection.prompts.count), collection_requests_path(collection)) %></dd>
<% end %>
<dt class="works"><%= ts("Works:") %></dt>
<dd class="works"><%= link_to(collection.approved_works_count, collection_works_path(collection)) %></dd>
<dt class="works"><%= t(".works") %></dt>

Check failure on line 52 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `works` detected matching the pattern `works`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:52:6: Deprecated class `works` detected matching the pattern `works`. Avoid the plural form of these classes.
<dd class="works"><%= link_to(number_with_delimiter(collection.approved_works_count), collection_works_path(collection)) %></dd>

Check failure on line 53 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `works` detected matching the pattern `works`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:53:6: Deprecated class `works` detected matching the pattern `works`. Avoid the plural form of these classes.
<% if (@bookmarks_count = collection.approved_bookmarked_items_count) > 0 %>
<dt class="bookmarks"><%= ts("Bookmarked Items:") %></dt>
<dd class="bookmarks"><%= link_to(@bookmarks_count, collection_bookmarks_path(collection)) %></dd>
<dt class="bookmarks"><%= t(".bookmarked_items") %></dt>

Check failure on line 55 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `bookmarks` detected matching the pattern `bookmarks`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:55:8: Deprecated class `bookmarks` detected matching the pattern `bookmarks`. Avoid the plural form of these classes.
<dd class="bookmarks"><%= link_to(number_with_delimiter(@bookmarks_count), collection_bookmarks_path(collection)) %></dd>

Check failure on line 56 in app/views/collections/_collection_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Deprecated class `bookmarks` detected matching the pattern `bookmarks`. Avoid the plural form of these classes.

Raw Output:
app/views/collections/_collection_blurb.html.erb:56:8: Deprecated class `bookmarks` detected matching the pattern `bookmarks`. Avoid the plural form of these classes.
<% end %>
</dl>

Expand Down
4 changes: 4 additions & 0 deletions config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,9 +771,13 @@ en:
collection_tags: 'Collection tags:'
collections:
collection_blurb:
bookmarked_items: 'Bookmarked Items:'
challenges_subcollections: 'Challenges/Subcollections:'
collection_tags: 'Collection Tags:'
prompts: 'Prompts:'
signups_close_at: 'Sign-ups close at:'
summary: Summary
works: 'Works:'
filters:
clear_filters: Clear Filters
closed:
Expand Down
Loading