Skip to content

AO3-7394 - If tag name is in error state, display old name instead #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mellowmarsach wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −1
Open

AO3-7394 - If tag name is in error state, display old name instead #5787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfc7e53
A03-7394 - If tag name is in error state, display old name instead
mellowmarsach May 5, 2026
a51b516
A03-7394 Cleanup
mellowmarsach May 5, 2026
40c94ea
AO3-7394 Rubocop
mellowmarsach May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/helpers/tags_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def wrangler_list(wranglers, tag)
end

def link_to_tag(tag, options = {})
link_to_tag_with_text(tag, tag.display_name, options)
display_name = tag.errors.key?(:name) ? tag.name_was : tag.display_name
link_to_tag_with_text(tag, display_name, options)
end

def link_to_tag_works(tag, options = {})
Expand Down
1 change: 1 addition & 0 deletions features/tags_and_wrangling/tag_wrangling_special.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Feature: Tag Wrangling - special cases
When I fill in "Name" with "Amelia"
And I press "Save changes"
Then I should see "Name can only be changed by an admin."
And I should see "Edit Amelie Tag"

Scenario: Change capitalisation of a tag

Expand Down
Loading