AO3-7414 Display error messages for multi-URL import

app/controllers/works_controller.rb

@@ -537,7 +537,12 @@ def import_multiple(urls, options)
 
     # collect the errors neatly, matching each error to the failed url
     unless failed_urls.empty?
-      error_msgs = 0.upto(failed_urls.length).map { |index| "<dt>#{failed_urls[index]}</dt><dd>#{errors[index]}</dd>" }.join("\n")
+      error_msgs = (0...failed_urls.length).map do |index|
+        # each failed url may have multiple errors, so show them in a bulleted list underneath the url
+        errors_per_url = errors[index].map { |error| "<li>#{error}</li>" }
+          .join("\n")
+        "<dt>#{failed_urls[index]}</dt><ul>#{errors_per_url}</ul>"
+      end.join("\n")
       flash.now[:error] = "<h3>#{ts('Failed Imports')}</h3><dl>#{error_msgs}</dl>".html_safe
     end
 

app/models/story_parser.rb

@@ -178,7 +178,7 @@ def import_from_urls(urls, options = {})
           works << work
         else
           failed_urls << url
-          errors << work.errors.values.join(", ")
+          errors << work.errors.full_messages
           work.delete if work
         end
       rescue Timeout::Error

spec/controllers/works/works_controller_spec.rb

@@ -24,4 +24,37 @@
       end
     end
   end
+
+  describe ".import_multiple" do
+    context "when the import has a failure from at least one URL" do
+      before do
+        allow_any_instance_of(StoryParser).to receive(:import_from_urls).and_return([
+          [],
+          urls,
+          [["failedurl1 first error", "failedurl1 second error"], ["failedurl2 first error"]]
+        ])
+        allow(controller).to receive(:render).with(:new_import)
+      end
+      let(:urls) { ["https://www.failedurl1.com", "https://www.failedurl2.com"] }
+
+      it "returns a well-formatted error message" do
+        expect(controller).to receive(:render).with(:new_import)
+        controller.send(:import_multiple, urls, {})
+        expect(flash[:error]).to eq(
+          "<h3>Failed Imports</h3>" \
+          "<dl>" \
+          "<dt>https://www.failedurl1.com</dt>" \
+          "<ul>" \
+          "<li>failedurl1 first error</li>\n" \
+          "<li>failedurl1 second error</li>" \
+          "</ul>\n" \
+          "<dt>https://www.failedurl2.com</dt>" \
+          "<ul>" \
+          "<li>failedurl2 first error</li>" \
+          "</ul>" \
+          "</dl>"
+        )
+      end
+    end
+  end
 end