Skip to content

AO3-7413 Unify new external bookmark page naming #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gemmie wants to merge 5 commits into
base: master
Choose a base branch
from
Open

AO3-7413 Unify new external bookmark page naming #5796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
412f921
AO3-7413 new external bookmark naming
gemmie May 8, 2026
3bd8e73
AO3-7413 fix translations
gemmie May 8, 2026
ef58af0
AO3-7413 normalise locale file
gemmie May 8, 2026
e979f75
add a test
gemmie May 8, 2026
1c02686
fix: move controller translations to proper place
gemmie May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/external_works_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ class ExternalWorksController < ApplicationController
before_action :check_user_status, only: [:new]

def new
@page_subtitle = t(".page_title")
@bookmarkable = ExternalWork.new
@bookmark = Bookmark.new
end
Expand Down
2 changes: 1 addition & 1 deletion app/views/external_works/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<h2 class="heading"><%= ts("Bookmark an external work") %></h2>
<h2 class="heading"><%= t(".page_heading") %></h2>
<%= render 'bookmarks/bookmark_form', :bookmarkable => @bookmarkable, :bookmark => @bookmark, :button_name => ts("Create"), :action => 'create' %>
2 changes: 2 additions & 0 deletions config/locales/controllers/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ en:
timeout_error:
browser_title: Timeout Error
external_works:
new:
page_title: Bookmark External Work
update:
successfully_updated: External work was successfully updated.
fandoms:
Expand Down
2 changes: 2 additions & 0 deletions config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,6 +1076,8 @@ en:
external_works:
edit:
works_languages_help_title: Languages help
new:
page_heading: Bookmark External Work
notice: This work isn't hosted on the Archive so this blurb might not be complete or accurate.
fandoms:
index:
Expand Down
5 changes: 5 additions & 0 deletions features/bookmarks/bookmark_external.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,8 @@ Feature: Create bookmarks of external works
When I follow "A Work Not Posted To The AO3"
Then I should see "This work isn't hosted on the Archive"
And I should see a link to "https://example.com/external_work" within "h4"

Scenario: A user should see the correct title on the external bookmark page
Given I am logged in as "bookmarker"
When I am on the new external work page
Then I should see the page title "Bookmark External Work"
Loading