Skip to content

AO3-7407 Add anonymous class to works and series blurbs and modules #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarken wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AO3-7407 Add anonymous class to works and series blurbs and modules #5799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/gifts/_gift_blurb.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% # expects "work" and "gift" %>
<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>gift work <%= css_classes_for_creation_blurb(work) %>" role="article">
<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.anonymous? %>anonymous <% end %><% if work.unrevealed? %>mystery <% end %>gift work <%= css_classes_for_creation_blurb(work) %>" role="article">
<%= render "works/work_module", work: work %>
<% if @user && @user == current_user && (gift = work.gifts.where(:pseud_id => current_user.pseuds.pluck(:id)).first) %>
<h6 class="landmark heading"><%= ts("Recipient Actions") %></h6>
Expand Down
4 changes: 2 additions & 2 deletions app/views/series/_series_blurb.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<li id="series_<%= series.id %>" class="<% if is_author_of?(series) %>own <% end %>series <%= css_classes_for_creation_blurb(series) %>" role="article">
<li id="series_<%= series.id %>" class="<% if is_author_of?(series) %>own <% end %><% if series.anonymous? %>anonymous <% end %>series <%= css_classes_for_creation_blurb(series) %>" role="article">
<%= render 'series/series_module', :series => series %>
<% if is_author_of?(series) %>
<h6 class="landmark heading"><%= ts("Author Actions") %></h6>
<p class="actions" role="navigation"><%= link_to ts('Edit'), edit_series_path(series) %></p>
<p class="actions"><%= link_to ts('Edit'), edit_series_path(series) %></p>

Check failure on line 5 in app/views/series/_series_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/series/_series_blurb.html.erb:5:38: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<% end %>
</li>
2 changes: 1 addition & 1 deletion app/views/series/_series_module.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<%# expects "series" %>

<!--title etc-->
<div class="header module">
<div class="<% if series.anonymous? %>anonymous <% end %>header module">
<h4 class="heading">
<%= t(".series_by_html", series_title_link: link_to(series.title, series), byline: byline(series)) %>
<% if series.restricted %>
Expand Down
6 changes: 3 additions & 3 deletions app/views/works/_work_blurb.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<% # expects "work" %>
<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
<li id="work_<%= work.id %>" class="<% if is_author_of?(work) %>own <% end %><% if work.anonymous? %>anonymous <% end %><% if work.unrevealed? %>mystery <% end %>work <%= css_classes_for_creation_blurb(work) %>" role="article">
<%= render "works/work_module", work: work %>
<% if is_author_of?(work) %>
<h6 class="landmark heading"><%= ts("Author Actions") %></h6>
<ul class="actions" role="navigation">
<ul class="actions">

Check failure on line 6 in app/views/works/_work_blurb.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Indent with spaces instead of tabs.

Raw Output:
app/views/works/_work_blurb.html.erb:6:0: Indent with spaces instead of tabs.
<li><%= link_to ts("Edit"), edit_work_path(work) %></li>
<li><%= link_to ts("Edit Tags"), edit_tags_work_path(work) %></li>
<% if work.is_wip %>
Expand All @@ -13,7 +13,7 @@
<li>
<%= link_to ts("Post Draft"), post_draft_work_path(work), method: :put %>
</li>
<li role="button">
<li>
<%= link_to ts("Delete Draft"), confirm_delete_work_path(work), data: { confirm: ts("Are you sure you want to delete this draft?") } %>
</li>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/works/_work_module.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= render "works/mystery_blurb", item: work %>
<% else %>
<!--title, author, fandom-->
<div class="header module">
<div class="<% if work.anonymous? %>anonymous <% end %>header module">
<!-- updated_at=<%= work.updated_at.to_i.to_s %> -->
<h4 class="heading">
<% if (work.unrevealed? || work.anonymous?) && (is_author_of?(work) || User.current_user.is_a?(Admin)) %>
Expand Down
Loading