AO3-6390 Remove the field for setting the default skin on the admin skins page#5815
Open
brianjaustin wants to merge 1 commit into
Open
AO3-6390 Remove the field for setting the default skin on the admin skins page#5815brianjaustin wants to merge 1 commit into
brianjaustin wants to merge 1 commit into
Conversation
…kins page This reverts commit 38bbe63. Co-authored-by: ScottVenkataraman <109530825+ScottVenkataraman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 38bbe63. It reintroduces #5676.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6390
Purpose
What does this PR do?
This PR removes the field for super admins to update the default skin from the /admin/skins/index_approved page.
It removes the functionality to accept entering direct URL request to effect the same change.
It updates tests to reflect these changes.
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
Follow Jira Ticket instruction for manual testing: https://otwarchive.atlassian.net/browse/AO3-6390
Credit
Scott Venkataraman he/him (Svenkat on Jira)