Skip to content

fix: replace strdup(error) with nginx pool allocation in config handlers #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eilandert wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −4
Open

fix: replace strdup(error) with nginx pool allocation in config handlers #382

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef5cb58
fix: replace strdup(error) with nginx pool allocation in config handlers
eilandert May 13, 2026
0dc8f95
fix: cast ngx_pstrdup return to char* to satisfy -Werror=pointer-sign
eilandert May 13, 2026
9d91d56
style: remove trailing whitespace in comment
eilandert May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ngx_http_modsecurity_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ ngx_conf_set_rules(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

if (res < 0) {
dd("Failed to load the rules: '%s' - reason: '%s'", rules, error);
return strdup(error);
return (char *) ngx_pstrdup(cf->pool, &(ngx_str_t){ngx_strlen(error), (u_char *)error});
}

mmcf = ngx_http_conf_get_module_main_conf(cf, ngx_http_modsecurity_module);
Expand Down Expand Up @@ -401,7 +401,7 @@ ngx_conf_set_rules_file(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

if (res < 0) {
dd("Failed to load the rules from: '%s' - reason: '%s'", rules_set, error);
return strdup(error);
return (char *) ngx_pstrdup(cf->pool, &(ngx_str_t){ngx_strlen(error), (u_char *)error});
}

mmcf = ngx_http_conf_get_module_main_conf(cf, ngx_http_modsecurity_module);
Expand Down Expand Up @@ -440,7 +440,7 @@ ngx_conf_set_rules_remote(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

if (res < 0) {
dd("Failed to load the rules from: '%s' - reason: '%s'", rules_remote_server, error);
return strdup(error);
return (char *) ngx_pstrdup(cf->pool, &(ngx_str_t){ngx_strlen(error), (u_char *)error});
}

mmcf = ngx_http_conf_get_module_main_conf(cf, ngx_http_modsecurity_module);
Expand Down Expand Up @@ -580,7 +580,7 @@ ngx_http_modsecurity_init(ngx_conf_t *cf)
}
/**
*
* We want to process everything in the NGX_HTTP_ACCESS_PHASE because we need to allow
* We want to process everything in the NGX_HTTP_ACCESS_PHASE because we need to allow
* ngx_http_limit_*_module to run
*
*/
Expand Down
Loading