Memoize useQuickActions internally, make useMemo unnecessary at callsites#3132
Open
david-crespo wants to merge 1 commit intoquick-actions-refactorfrom
Open
Memoize useQuickActions internally, make useMemo unnecessary at callsites#3132david-crespo wants to merge 1 commit intoquick-actions-refactorfrom
useQuickActions internally, make useMemo unnecessary at callsites#3132david-crespo wants to merge 1 commit intoquick-actions-refactorfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #3131 because it's completely mechanical and all noise.
TIL
additionalHooks, which lets you opt your own hooks into the dependency checking the linter does foruseEffectanduseMemo. This means we can turnuseQuickActionsinto something that takes a function and a dep array and skip theuseMemo. This is better because there was nothing preventing you from just forgetting theuseMemo. Now it's built in. And it works: if you take one of the deps out of one of the arrays, you get the lint error.The diff is very small if you hide whitespace changes.