Skip to content

Undo disabling synchronous writeback#10088

Draft
smklein wants to merge 1 commit intomainfrom
enable-synchronization
Draft

Undo disabling synchronous writeback#10088
smklein wants to merge 1 commit intomainfrom
enable-synchronization

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Mar 18, 2026

Reverts the original optimization

Fixes #10085

@smklein
Copy link
Collaborator Author

smklein commented Mar 18, 2026

Posting this as a draft first to observe the performance impact

@smklein
Copy link
Collaborator Author

smklein commented Mar 18, 2026

We're hitting #10005 here - it gets exaggerated without this optimization. Frankly it should be fixed independently of this synchronization stuff, but highlighting it as a problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CockroachDB's disable_synchronization_unsafe in tests causes unsynchronized writes

1 participant