schema: add fm_support_bundle_request table, per-variant data selection tables, and fm_case_id on support_bundle#10091
Draft
mergeconflict wants to merge 3 commits intomainfrom
Draft
schema: add fm_support_bundle_request table, per-variant data selection tables, and fm_case_id on support_bundle#10091mergeconflict wants to merge 3 commits intomainfrom
mergeconflict wants to merge 3 commits intomainfrom
Conversation
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
83e6642 to
d14e835
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
2 times, most recently
from
2baa491 to
c2191f0
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
d14e835 to
239ff2c
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
c2191f0 to
e725e86
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
239ff2c to
a3cd348
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
e725e86 to
beef2af
Compare
Move BundleDataCategory, BundleData, BundleDataSelection, and SledSelection to nexus/types/src/support_bundle.rs. Move EreportFilters to nexus/types/src/fm/ereport.rs (where it belongs alongside other ereport types). Update all consumers to import directly. Pure refactor, no behavior change.
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
beef2af to
1f1c514
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
a3cd348 to
a11968f
Compare
mergeconflict
requested review from
hawkw,
jgallagher and
smklein
and removed request for
jgallagher and
smklein
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
a11968f to
c25bd47
Compare
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
1f1c514 to
ad04192
Compare
Member
Just as a point of process, while I am also a fan of trying to split changes up into multiple smaller, individually-reviewable PRs, in this case, I feel like we could probably have included the models in the same branch as the schema changes. |
Member
|
Also, it looks like you need to do this thing which we now have to do, due to sadness. |
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
ad04192 to
accc0bd
Compare
…ield Add the SupportBundleRequest type to fm::case and the support_bundles_requested field to Case. Add Display impls for BundleData, BundleDataSelection, SledSelection, and EreportFilters so that case formatting can show the full data selection for each requested support bundle. Add Serialize/Deserialize derives to the support bundle selection types (BundleDataSelection, BundleData, BundleDataCategory, SledSelection, EreportFilters) since SupportBundleRequest contains Option<BundleDataSelection>. Add proptest Arbitrary impls for BundleDataSelection and EreportFilters (in test_utils modules) and a proptest-based serde round-trip test for BundleDataSelection. Add test_case_display coverage for support bundle requests, exercising both data_selection: None and Some with parameterized categories.
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
accc0bd to
bd75858
Compare
…on tables, and fm_case_id on support_bundle Add migration SQL for fm_support_bundle_request and five per-variant data selection tables (reconfigurator, sled_cubby_info, sp_dumps, host_info, ereports). Add fm_case_id column to support_bundle. Update dbinit.sql, Diesel schema, and schema version.
mergeconflict
force-pushed
the
mergeconflict/fm-sb-schema
branch
from
c25bd47 to
2604576
Compare
Collaborator
The alternative is asynchronous schema changes, where you don't really know when they're done. So trust me, this is the less bad option! |
hawkw
added
the
fault-management
mergeconflict
force-pushed
the
mergeconflict/fm-sb-types
branch
from
bd75858 to
0914f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the DB schema and corresponding Diesel
table!declarations for storing support bundle requests. That basically looks like:fm_support_bundle_requesttable.BundleDataconstructor, indicating what bundle data was requested.This also includes the migration scripts. It notably does not include any models; that's coming in PR #10095. Context: #10062.