[1/n] [reconfigurator] better behavior when no sleds are in-service#10328
Open
sunshowers wants to merge 3 commits intomainfrom
Open
[1/n] [reconfigurator] better behavior when no sleds are in-service#10328sunshowers wants to merge 3 commits intomainfrom
sunshowers wants to merge 3 commits intomainfrom
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was found during some property-based/chaos testing for the planner I started working on.
This is a bit of a contrived case -- if no sleds are in-service, where is planner code actually running? -- but it currently produces a slightly misleading programming error:
Fixing this isn't a huge deal for production, but it does allow the property-based tests to proceed without having to try and special-case the no-sleds-in-service scenario.