[RSS] Move switch_port table population to a Nexus bg task#10370
Open
jgallagher wants to merge 1 commit intomainfrom
Open
[RSS] Move switch_port table population to a Nexus bg task#10370jgallagher wants to merge 1 commit intomainfrom
switch_port table population to a Nexus bg task#10370jgallagher wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please start reviewing with the module-level comments in
nexus/src/app/background/tasks/populate_switch_ports.rs; they attempt to explain the history and motivation of this change. It's probably the most important thing to review - if any of that reasoning is wrong, the change I'm making in this PR probably is too!This is (preemptively) removing one of the internal-to-sled-agent uses of the
early_networkingmodule, in the hopes that we can eventually remove it entirely. Also closes #3069.