ci: change deploy.sh to programmatically enumerate disks#10383
Open
ci: change deploy.sh to programmatically enumerate disks#10383
deploy.sh to programmatically enumerate disks#10383Conversation
At present, the `deploy.sh` buildomat job hard-codes the disk names `c1t1d0` and `c2t1d0` when creating a scratch zpool. This means that, should the job run on a computer which does not have disks by those names, it will, of course, not work. This is sad because, after `sock` was pulled from the Build-O-Mat worker pool due to a failed disk, the replacement NVMe device shows up with a WWN in its name and therefore breaks the hard-coded assumption. We really should never have been doing that. Thus, this commit changes it to just list NVMe block device names by invoking `nvmeadm list -p -o disk`, and using the returned block devices to create the scratch zpool. This should work no matter what NVMe devices @InternalIncident puts in the two new imminently arriving buildomat workers, too! Yay! Fixes #10354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the
deploy.shbuildomat job hard-codes the disk namesc1t1d0andc2t1d0when creating a scratch zpool. This means that, should the job run on a computer which does not have disks by those names, it will, of course, not work. This is sad because, aftersockwas pulled from the Build-O-Mat worker pool due to a failed disk, the replacement NVMe device shows up with a WWN in its name and therefore breaks the hard-coded assumption. We really should never have been doing that.Thus, this commit changes it to just list NVMe block device names by invoking
nvmeadm list -p -o disk, and using the returned block devices to create the scratch zpool. This should work no matter what NVMe devices @InternalIncident puts in the two new imminently arriving buildomat workers, too! Yay!Fixes #10354