Open
Conversation
iximeow
added
the
development
iximeow
commented
Mar 19, 2026
| /// `access_locked()`, and *may* block attempts to `access()` or | ||
| /// `access_locked()` a child of this node. Holding this guard will block | ||
| /// removal of the underlying resource, potentially blocking VM teardown. | ||
| pub fn access_locked(&self) -> Option<LockedView<'_, T>> { |
Member
Author
There was a problem hiding this comment.
this is partially motivated by #1080, in that in retrospect i don't think access_borrow() at the caller side really communicates that an access() -> access_borrow() diff really changes the caller's relationship with accessor node locking. this hopefully encourages more scrutiny of such a change (and the additional words should ward away uses without good rationale)
Member
Author
|
(i'd mentioned to Eliza i was trying to put this to words a bit ago, but i'd appreciate eyes from anyone who's been looking the word |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm decreasingly burdened by awareness of my sinuses, and managed to put words together yesterday! yay!
talking with a few folks since ~January has both helped me better describe why the accessor stuff is how it is, and how authors of code in the Propolis library crate might want to think about it. also, in those conversations it became very clear that putting that to words in a module comment would have been helpful to people trying to figure out how to use this right.
so, hopefully i've channeled Patrick satisfactorily and folks find this enlightening. this is, at the least, how i find myself thinking about it!