Skip to content

fix: race condition fractionRegistry stats #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eguguchkin wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix: race condition fractionRegistry stats #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions fracmanager/fraction_registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,12 @@ func (r *fractionRegistry) AllFractions() []frac.Fraction {
// Stats returns current size statistics of the registry.
func (r *fractionRegistry) Stats() registryStats {
r.mu.RLock()
defer r.mu.RUnlock()
s := r.stats
i := r.active.instance.Info()
r.mu.RUnlock()

r.stats.active.Set(r.active.instance.Info())
return r.stats
s.active.Set(i)
return s
}

// OldestTotal returns the creation time of the oldest fraction in the registry.
Expand Down
Loading