Added page with monitoring instuctions #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdii
requested changes
Jul 8, 2024
Member
erdii
left a comment
erdii
left a comment
There was a problem hiding this comment.
Thanks Rob, this looks good. :)
I'd have two change requests though:
- Can you please specify in the docs that they explain how to monitor the package-operator-manager pod (or does this also monitor the webhook pods?)
- Can you please specify that this doc is about monitoring pko with prometheus-operator?
Member
|
And maybe also mention that prom must be able to actually reach the pods (which maybe sometimes isn't the case because of NetworkPolicies or other firewall solutions in the way) |
erdii
requested changes
Jul 18, 2024
Member
erdii
left a comment
erdii
left a comment
There was a problem hiding this comment.
looks good - requested a wording change.
I see that the original ticket also includes alerting in the documentation but I'd assume that this can be split out from the general setup of monitoring since we don't have any alerts yet?
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for monitoring PKO.