Skip to content

Adding note about development dependency on libpq-devel#438

Open
jpodivin wants to merge 2 commits intopackit:mainfrom
jpodivin:postgresdevel
Open

Adding note about development dependency on libpq-devel#438
jpodivin wants to merge 2 commits intopackit:mainfrom
jpodivin:postgresdevel

Conversation

@jpodivin
Copy link
Copy Markdown
Collaborator

@jpodivin jpodivin commented May 4, 2026

Couple of things in README.md need updating.

When installing dependencies with ai-workflows with uv sync one can get an error when building psycopg2:

 × Failed to build `psycopg2==2.9.12`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta:__legacy__.build_wheel` failed (exit status: 1)

      [stdout]
      running egg_info
      writing psycopg2.egg-info/PKG-INFO
      writing dependency_links to psycopg2.egg-info/dependency_links.txt
      writing top-level names to psycopg2.egg-info/top_level.txt

      [stderr]
      /home/jpodivin/.cache/uv/builds-v0/.tmpuEJopq/lib64/python3.13/site-packages/setuptools/dist.py:765: SetuptoolsDeprecationWarning: License classifiers are deprecated.
      !!

              ********************************************************************************
              Please consider removing the following classifiers in favor of a SPDX license expression:

              License :: OSI Approved :: GNU Library or Lesser General Public License (LGPL)

              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
              ********************************************************************************

      !!
        self._finalize_license_expression()

      Error: pg_config executable not found.

      pg_config is required to build psycopg2 from source.  Please add the directory
      containing pg_config to the $PATH or specify the full executable path with the
      option:

          python setup.py build_ext --pg-config /path/to/pg_config build ...

      or with the pg_config option in 'setup.cfg'.

      If you prefer to avoid building psycopg2 from source, please install the PyPI
      'psycopg2-binary' package instead.

      For further information please check the 'doc/src/install.rst' file (also at
      <https://www.psycopg.org/docs/install.html>).


      hint: This usually indicates a problem with the package or the build environment.
  help: `psycopg2` (v2.9.12) was included because `ymir` (v0.1.0) depends on `nitrate` (v1.9.0) which depends on `psycopg2`

The binary pg_config obviously isn't packaged with Fedora by default, you have to install it. One of the options, is libpq-devel. Which should be available in standard repos.

Also, installing standard dependencies is not enough for development. One also needs dependencies in the test group.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md file to include libpq-devel in the list of required system packages. A review comment suggests sorting the package list alphabetically to enhance maintainability and readability.

Comment thread README.md

```
python3-devel podman-compose gcc krb5-devel
python3-devel podman-compose gcc krb5-devel libpq-devel
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of system packages should be alphabetically sorted to improve maintainability and readability. This makes it easier to identify missing or redundant packages as the project grows.

Suggested change
python3-devel podman-compose gcc krb5-devel libpq-devel
gcc krb5-devel libpq-devel podman-compose python3-devel

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@jpodivin jpodivin requested a review from nforro May 4, 2026 12:57
Copy link
Copy Markdown
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants