OpenShift: improve deployment reliability and egress access#443
Open
TomasTomecek wants to merge 7 commits intopackit:mainfrom
Open
OpenShift: improve deployment reliability and egress access#443TomasTomecek wants to merge 7 commits intopackit:mainfrom
TomasTomecek wants to merge 7 commits intopackit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenShift deployment configuration by introducing a new deployment script with retry logic, enabling the Phoenix observability stack, and renaming the DRY_RUN environment variable to SILENT_RUN. It also updates the README with deployment locations and adds egress rules for Google OAuth and Vertex AI. Feedback includes addressing shell portability issues in the deployment script, removing redundant namespace flags, and ensuring the retry logic matches the intended exponential backoff. Additionally, it is recommended to reference environment variables from ConfigMaps for better maintainability and to refine broad egress rules for Google APIs.
| retry=$((retry + 1)) | ||
| if [ $retry -lt $max_retries ]; then | ||
| echo "Import failed, retrying in 2 seconds... (attempt $retry/$max_retries)" | ||
| sleep 2 |
Contributor
Retries up to 5 times with exponential backoff (2s, 4s, 8s, 16s) when oc import-image fails, handling transient conflicts during concurrent ImageStream updates. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com> Assisted-by: Claude
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
that I just shamelessly copy-pasted from Anton's repo 🙈 we'll figure this out longterm Related https://github.com/packit/ai-workflows/pull/409/changes Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Added oauth2.googleapis.com, vertexai.googleapis.com, and googleapis.com to egress rules to enable authentication with Vertex AI for Claude API calls. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
lbarcziova
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve OpenShift deployment reliability and enable LLM access via Vertex AI.
Changes
Egress & Networking:
Deployment Script:
oc import-imagewith exponential backoff (2s, 4s, 8s, 16s delays, max 5 attempts) to handle transient OpenShift conflictsDocumentation: