Skip to content

Mocking upgrade#450

Merged
TomasKorbar merged 11 commits intopackit:mainfrom
TomasKorbar:mocking_upgrade
May 6, 2026
Merged

Mocking upgrade#450
TomasKorbar merged 11 commits intopackit:mainfrom
TomasKorbar:mocking_upgrade

Conversation

@TomasKorbar
Copy link
Copy Markdown
Collaborator

@TomasKorbar TomasKorbar commented May 5, 2026

  • Extract mock repo setup from e2e tests into a shared ymir/common/mock_repos.py module so the same mocking infrastructure can be reused for all mocking
  • Add RunShellCommandTool URL blocking via MOCK_BLOCKED_URLS to prevent agents from bypassing mocked repos with curl/wget, replacing the previous shell wrapper approach
  • Add scripts/run-mock-triage.py launcher and claude-triage-mock.md guide for running the triage skill against mocked JIRA data locally

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive mocking framework for the triage skill, allowing local execution against mocked JIRA data and CentOS Stream repositories. Key additions include a new utility module for repo fixtures, a launcher script for Claude Code, and updated documentation. Feedback focuses on ensuring proper cleanup of temporary files and directories, specifically addressing the use of os.execvp which bypasses atexit handlers and the lack of deletion for temporary mock repository directories.

Comment thread scripts/run-mock-triage.py Outdated
Comment thread ymir/common/mock_repos.py
Comment thread ymir/common/mock_repos.py Outdated
Comment thread ymir/agents/triage_agent.py Outdated
Comment thread ymir/tools/unprivileged/commands.py Outdated
Comment thread ymir/tools/unprivileged/commands.py Outdated
@TomasKorbar TomasKorbar merged commit efcc1fb into packit:main May 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants