Mocking upgrade#450
Merged
TomasKorbar merged 11 commits intopackit:mainfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive mocking framework for the triage skill, allowing local execution against mocked JIRA data and CentOS Stream repositories. Key additions include a new utility module for repo fixtures, a launcher script for Claude Code, and updated documentation. Feedback focuses on ensuring proper cleanup of temporary files and directories, specifically addressing the use of os.execvp which bypasses atexit handlers and the lack of deletion for temporary mock repository directories.
2484341 to
e3eff38
Compare
nforro
reviewed
May 5, 2026
dc0a0e8 to
2d761e1
Compare
nforro
reviewed
May 6, 2026
nforro
reviewed
May 6, 2026
nforro
reviewed
May 6, 2026
nforro
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.