Skip to content

Add operation-type labels to MRs for tracking statistics#452

Open
lbarcziova wants to merge 1 commit intopackit:mainfrom
lbarcziova:mr-operation-labels
Open

Add operation-type labels to MRs for tracking statistics#452
lbarcziova wants to merge 1 commit intopackit:mainfrom
lbarcziova:mr-operation-labels

Conversation

@lbarcziova
Copy link
Copy Markdown
Member

Label each MR with ymir_backport, ymir_rebase, or ymir_rebuild so we can query GitLab for per-operation statistics.

Assisted-by: Claude Opus 4.6

Label each MR with ymir_backport, ymir_rebase, or ymir_rebuild
so we can query GitLab for per-operation statistics.

Assisted-by: Claude Opus 4.6
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to apply labels to merge requests generated by the backport, rebase, and rebuild agents. The commit_push_and_open_mr function was updated to handle label assignment through a new tool call. Feedback focuses on moving hardcoded label strings to a centralized constants file to improve code maintainability and prevent errors.

),
available_tools=gateway_tools,
commit_only=dry_run,
labels=["ymir_backport"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The label "ymir_backport" is a hardcoded string used for tracking statistics. It should be defined as a constant in ymir/agents/constants.py to ensure consistency across the codebase and avoid potential typos in future updates.

),
available_tools=gateway_tools,
commit_only=dry_run,
labels=["ymir_rebase"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The label "ymir_rebase" is a hardcoded string used for tracking statistics. It should be defined as a constant in ymir/agents/constants.py to ensure consistency across the codebase and avoid potential typos in future updates.

available_tools=gateway_tools,
commit_only=dry_run,
allow_empty=is_empty_commit,
labels=["ymir_rebuild"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The label "ymir_rebuild" is a hardcoded string used for tracking statistics. It should be defined as a constant in ymir/agents/constants.py to ensure consistency across the codebase and avoid potential typos in future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant