Reject unmerged patches as backport candidates in triage#453
Reject unmerged patches as backport candidates in triage#453lbarcziova wants to merge 1 commit intopackit:mainfrom
Conversation
Add validation rule to triage prompt requiring patches to come from merged/accepted upstream commits. Unmerged PRs, bug tracker attachments, mailing list proposals, and fork branches must not be used for backport decisions — they can be mentioned in clarification-needed notes instead. Assisted-by: Claude Opus 4.6
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new validation rule to the triage skill and agent, requiring that only merged or accepted fixes be used for backporting while explicitly excluding unmerged proposals or attachments. Review feedback indicates that subsequent references to "both validations" in both the documentation and the agent's logic need to be updated to reflect the addition of this third criterion to maintain consistency.
| 2. **Does it fix the issue?** Verify that the code changes directly address the root cause, align with the symptoms, and modify the functions/files mentioned in the issue. | ||
| * Only proceed with URLs that contain valid patch content AND address the specific issue. | ||
| * If the content is not a proper patch or doesn't fix the issue, continue searching. | ||
| * **Only use merged/accepted fixes**: Patches must come from commits that have been merged into the upstream repository (or Fedora). Do NOT use patches from: |
There was a problem hiding this comment.
The addition of this third validation rule makes the subsequent references to "both validations" (on lines 415 and 418) inaccurate. Please update those references to "all three validations" or similar to maintain consistency throughout the skill instructions.
| - The modified functions/files match those mentioned in the issue | ||
| * Only proceed with URLs that contain valid patch content AND address the specific issue | ||
| * If the content is not a proper patch or doesn't fix the issue, continue searching for other fixes | ||
| * **Only use merged/accepted fixes**: Patches must come from commits that have been |
There was a problem hiding this comment.
This new validation rule is added to section 2.3, but the subsequent "Decide the Outcome" section (2.4) still refers to "both validations in step 2.3" (lines 389 and 394). Please update those references to reflect that there are now three validation criteria to ensure the agent's logic remains consistent.
1 participant
Add validation rule to triage prompt requiring patches to come from merged/accepted upstream commits. Unmerged PRs, bug tracker attachments, mailing list proposals, and fork branches must not be used for backport decisions — they can be mentioned in clarification-needed notes instead.
Assisted-by: Claude Opus 4.6