Skip to content

Codetidy/nick johan/various fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohanKool3 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Codetidy/nick johan/various fixes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4362c7a
Codacy Fix - Changed Test Return Types To Task (Async methods should …
NickYoung-PanoramicData Jul 24, 2023
fc0069d
Codacy Fix - Removed commented out code (Sections of code should not …
NickYoung-PanoramicData Jul 24, 2023
d0a0712
Codetidy - Changed some constants to static readonly (Public constant…
NickYoung-PanoramicData Jul 24, 2023
1d2f7da
Codetidy - Removed partial from some classes (Redundant modifiers sho…
NickYoung-PanoramicData Jul 24, 2023
5d9c49e
Codacy Fix - Made some properties private (Fields should be private)
NickYoung-PanoramicData Jul 24, 2023
c71a173
Codacy Fix - Changed ConfigurationExpection to public (Exception type…
NickYoung-PanoramicData Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Cisco.Api.Test/EoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using Cisco.Api.Data.Eox;
using FluentAssertions;
using System;
using System.Globalization;
using System.Linq;
using System.Threading.Tasks;
using Cisco.Api.Data.Eox;
using FluentAssertions;
using Xunit;
using Xunit.Abstractions;

Expand All @@ -15,7 +16,7 @@ public EoxTests(ITestOutputHelper iTestOutputHelper) : base(iTestOutputHelper)
}

[Fact]
public async void GetByDatesAsync_Succeeds()
public async Task GetByDatesAsync_Succeeds()
{
var eoxInfoPage = await CiscoClient
.Eox
Expand All @@ -27,7 +28,7 @@ public async void GetByDatesAsync_Succeeds()
}

[Fact]
public async void GetByProductIdAsync_Succeeds()
public async Task GetByProductIdAsync_Succeeds()
{
var eoxInfoPage = await CiscoClient
.Eox
Expand All @@ -37,7 +38,7 @@ public async void GetByProductIdAsync_Succeeds()
}

[Fact]
public async void GetBySerialNumberAsync_Succeeds()
public async Task GetBySerialNumberAsync_Succeeds()
{
var eoxInfoPage = await CiscoClient
.Eox
Expand All @@ -47,7 +48,7 @@ public async void GetBySerialNumberAsync_Succeeds()
}

[Fact]
public async void GetBySoftwareReleaseStringAsync_Succeeds()
public async Task GetBySoftwareReleaseStringAsync_Succeeds()
{
var eoxInfoPage = await CiscoClient
.Eox
Expand Down
9 changes: 5 additions & 4 deletions Cisco.Api.Test/FieldNoticesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Cisco.Api.Data.Pss;
using System.Threading;
using System.Threading;
using System.Threading.Tasks;
using Cisco.Api.Data.Pss;
using Xunit;
using Xunit.Abstractions;

Expand All @@ -12,9 +13,9 @@ public FieldNoticesTests(ITestOutputHelper iTestOutputHelper) : base(iTestOutput
}

[Fact]
public async void Get_Succeeds()
public async Task Get_Succeeds()
{
var _ =
_ =
await CiscoClient.Pss.GetFieldNoticesAsync(
new FieldNoticesRequest
{
Expand Down
5 changes: 3 additions & 2 deletions Cisco.Api.Test/HelloTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Cisco.Api.Data.Hello;
using System.Threading.Tasks;
using Cisco.Api.Data.Hello;
using FluentAssertions;
using Xunit;
using Xunit.Abstractions;
Expand All @@ -12,7 +13,7 @@ public HelloTests(ITestOutputHelper iTestOutputHelper) : base(iTestOutputHelper)
}

[Fact]
public async void Hello_Succeeds()
public async Task Hello_Succeeds()
{
var response = await CiscoClient
.Hello
Expand Down
98 changes: 5 additions & 93 deletions Cisco.Api.Test/ProductInformationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using FluentAssertions;
using System.Linq;
using System.Threading.Tasks;
using FluentAssertions;
using Xunit;
using Xunit.Abstractions;

Expand All @@ -12,7 +13,7 @@ public ProductInformationTests(ITestOutputHelper iTestOutputHelper) : base(iTest
}

[Fact]
public async void GetBySerialNumberAsync_Fails()
public async Task GetBySerialNumberAsync_Fails()
{
// Note: If no serials are found, then Products will have 1 empty record (yet totals say 0) that also has ErrorResponse set
var productInformationPage = await CiscoClient
Expand All @@ -33,7 +34,7 @@ public async void GetBySerialNumberAsync_Fails()
}

[Fact]
public async void GetBySerialNumberAsync_Succeeds()
public async Task GetBySerialNumberAsync_Succeeds()
{
// Note: Serial numbers can be up to 40 chars long.
var productInformationPage = await CiscoClient
Expand Down Expand Up @@ -73,7 +74,7 @@ public async void GetBySerialNumberAsync_Succeeds()
}

[Fact]
public async void GetBySerialNumberMultipleAsync_Succeeds()
public async Task GetBySerialNumberMultipleAsync_Succeeds()
{
// Note: Serial numbers can be up to 40 chars long.
var productInformationPage = await CiscoClient
Expand Down Expand Up @@ -111,94 +112,5 @@ public async void GetBySerialNumberMultipleAsync_Succeeds()
productInformationPage.Products.Select(productInformation => productInformation.VisioStencilUrl).Should().NotBeNull();
productInformationPage.Products.Select(productInformation => productInformation.Weight).Should().NotBeNull();
}

//[Fact]
//public async void GetBySerialNumberMultipleAsync_Succeeds()
//{
// try
// {
// // serial numbers is limited to 40 characters!
// var serialNumbers = new[] {
// "FCW2234L10F",
// "FCW2234L12V",
// "FCW2408P0LF",
// "FCW2408P0LP",
// "FCW2408P0LR",
// "FCW2408P0LS",
// "FCW2408P0LT",
// "FCW2408P0LW",
// "FCW2408P0M0",
// "FCW2408P0M2",
// "FCW2408P0M6",
// "FCW2408P0M9",
// "FCW2408P0MA",
// "FCW2408P0MC",
// "FCW2408P0MD",
// "FCW2408P0MF",
// "FCW2408P0MG",
// "FCW2408P0MJ",
// "FCW2408P0MK",
// "FCW2408P0ML",
// "FCW2234L10E",
// "FCW2234G122",
// "FCW2408P0MN",
// "FCW2408P0MP",
// "FCW2408P0MQ",
// "FCW2408P0MR",
// "FCW2408P0MS",
// "FCW2408P0MT",
// "FCW2408P0MU",
// "FCW2408P0MW",
// "FCW2408P0MX",
// "FCW2408P0MY",
// "FCW2408P0MZ",
// "FCW2408P0N0",
// "FCW2408P0N2",
// "FCW2408P0N3",
// "FCW2408P0N4",
// "FCW2408P0N5",
// "FCW2408P0N7",
// "FCW2408P0N8",
// "FOC2308U19E",
// "FCW2311L110",
// "FCW2408P0N9",
// "FCW2408P0NA",
// "FCW2408P0NB",
// "FCW2408P0NC",
// "FCW2408P0ND",
// "FCW2408P0NE",
// "FCW2408P0NF",
// "FCW2408P0NG",
// "FCW2408P0NH",
// "FCW2408P0NJ",
// "FCW2408P0NK",
// "FCW2408P0NL",
// "FCW2408P0NN",
// "FCW2408P0NP",
// "FCW2408P0NQ",
// "FCW2408P0NR",
// "FCW2408P0NS",
// "FCW2408P0NT"
// };

// ProductInformationPage productInformationPage;
// var basePids = new List<string>();
// foreach (var serialNumber in serialNumbers)
// {
// productInformationPage = await CiscoClient
// .ProductInfo
// .GetBySerialNumbersAsync(new[] { serialNumber })
// .ConfigureAwait(false);

// basePids.Add(productInformationPage.Products.First().BasePid);
// }

// basePids = basePids.Distinct().ToList();
// }
// catch (Exception ex)
// {

// }
//}
}
}
7 changes: 4 additions & 3 deletions Cisco.Api.Test/PsirtTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Threading;
using System.Threading.Tasks;
using Cisco.Api.Data.Psirt;
using FluentAssertions;
using System.Threading;
using Xunit;
using Xunit.Abstractions;

Expand All @@ -13,7 +14,7 @@ public PsirtTests(ITestOutputHelper iTestOutputHelper) : base(iTestOutputHelper)
}

[Fact]
public async void GetPsirtByCveId()
public async Task GetPsirtByCveId()
{
var advisoryResponse = await CiscoClient
.Psirt
Expand All @@ -27,7 +28,7 @@ public async void GetPsirtByCveId()
}

[Fact]
public async void GetAllPsirts()
public async Task GetAllPsirts()
{
var advisoryResponse = await CiscoClient
.Psirt
Expand Down
Loading