test: Add Wycheproof-based AES-GCM tests #336
Open
+547
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testingapisname
force-pushed
the
add-wycheproof-tests
branch
from
4645dd5 to
18ad9f0
Compare
Jakuje
reviewed
Dec 17, 2025
Collaborator
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
thank you for your contribution! Just two thoughts regarding the PKCS#11 3.* API
cryptoki/tests/wycheproof.rs
Outdated
Comment on lines
43
to
44
| // Skip tests with nonce sizes that exceed PKCS#11 limits (max 256 bytes) | ||
| if test.nonce.len() > 256 { |
Collaborator
There was a problem hiding this comment.
While the PKCS#11 2.40 has this limitation [1], the higher limit is defined in the current specification 3.2:
The length of the initialization vector can be any number between 1 and (2^32) - 1.
In the tests, you can detect the pkcs11 version and I think we can use the larger ones for the new modules.
Updating the documentation would be good too
[1] https://docs.oasis-open.org/pkcs11/pkcs11-curr/v2.40/errata01/os/pkcs11-curr-v2.40-errata01-os-complete.html#_Toc441850509
[2] https://docs.oasis-open.org/pkcs11/pkcs11-spec/v3.2/pkcs11-spec-v3.2.html#_Toc195693377
| }; | ||
|
|
||
| // Test encryption | ||
| let encrypt_result = session.encrypt(&Mechanism::AesGcm(gcm_params), key, &test.pt); |
Collaborator
There was a problem hiding this comment.
Could we test also the PKCS#11 3 API with message-based encryption?
rust-cryptoki/cryptoki/tests/basic.rs
Line 2587 in 36fb3c3
testingapisname
added a commit
to testingapisname/rust-cryptoki
that referenced
this pull request
Dec 19, 2025
- Implement PKCS#11 version detection to apply appropriate nonce size limits * PKCS#11 2.40: 256 bytes (ulIvBits in bits, per spec section 5.16.3) * PKCS#11 3.x: 2^32-1 bytes (ulIvLen in bytes, per spec section 5.15.3) - Add aes_gcm_message_wycheproof() test for PKCS#11 3.0+ message API * Uses message_encrypt_init/encrypt_message/message_encrypt_final * Gracefully skips if provider doesn't support message-based encryption * Properly handles edge cases (zero-length plaintext, unusual nonce sizes) * Includes cleanup logic to prevent session state issues - All 316 Wycheproof tests pass with both SoftHSM 2.40 and Kryoptic 3.0+ Addresses reviewer feedback from PR parallaxsecond#336
Contributor
Author
Implements comprehensive AES-GCM testing using official Wycheproof test vectors from Google. Tests 313 valid cryptographic operations across multiple key sizes (128/192/256-bit), nonce lengths, tag sizes, and AAD configurations. Fixes parallaxsecond#187 Signed-off-by: James Eilers <eilersjames15@gmail.com>
- Implement PKCS#11 version detection to apply appropriate nonce size limits * PKCS#11 2.40: 256 bytes (ulIvBits in bits, per spec section 5.16.3) * PKCS#11 3.x: 2^32-1 bytes (ulIvLen in bytes, per spec section 5.15.3) - Add aes_gcm_message_wycheproof() test for PKCS#11 3.0+ message API * Uses message_encrypt_init/encrypt_message/message_encrypt_final * Gracefully skips if provider doesn't support message-based encryption * Properly handles edge cases (zero-length plaintext, unusual nonce sizes) * Includes cleanup logic to prevent session state issues - All 316 Wycheproof tests pass with both SoftHSM 2.40 and Kryoptic 3.0+ Addresses reviewer feedback from PR parallaxsecond#336 Signed-off-by: James Eilers <eilersjames15@gmail.com>
- Add provider limitation handling for nonces > 256 bytes - Fix second test to handle already-initialized PKCS#11 context - Restore detailed println output for all individual test results Signed-off-by: James Eilers <eilersjames15@gmail.com>
testingapisname
force-pushed
the
add-wycheproof-tests
branch
from
b8ec82d to
59234d1
Compare
Signed-off-by: James Eilers <eilersjames15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements comprehensive AES-GCM testing using official Wycheproof test vectors from Google. Tests 313 valid cryptographic operations across multiple key sizes (128/192/256-bit), nonce lengths, tag sizes, and AAD configurations.
Fixes #187