Skip to content

Conversation

@Superhepper
Copy link
Collaborator

In order to fix the lint problems it was necessary update MSRV to 1.76 and address the additional
lint problems that arose when that change was
introduced.

In order to fix the lint problems it was necessary
update MSRV to 1.76 and address the additional
lint problems that arose when that change was
introduced.

Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@Superhepper Superhepper marked this pull request as ready for review December 18, 2025 22:33
@Superhepper
Copy link
Collaborator Author

Please take an extra through look at the CreateCommandOutputHandler struct and see if it seems ok or is overly complicated?

@wiktor-k
Copy link
Collaborator

Please take an extra through look at the CreateCommandOutputHandler struct and see if it seems ok or is overly complicated?

What's the reason for wrapping pointers in Options there? 🤔

@Superhepper
Copy link
Collaborator Author

Please take an extra through look at the CreateCommandOutputHandler struct and see if it seems ok or is overly complicated?

What's the reason for wrapping pointers in Options there? 🤔

It is to indicate to the drop function if it needs to free any data. But it might be the case that I am paranoid and non of this is necessary. I am not sure if the specifications says that no pointers will be assigned if the API call does not finish successfully.

@wiktor-k
Copy link
Collaborator

I'm curious if that's related to lints (that is if any lint fires before you fix that?). If not I think these could be two different commits (I'm very interested in getting the lints merged ASAP but for Options we can take it slowly...). Thanks!

@Superhepper
Copy link
Collaborator Author

Yeah it fixes those lints as well but I do not think it is necessary to solve it in this manner. I think it would be enough to just not assign pointers to null once they have been used in order for the lint to go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants